Skip to content

Refactor code for readability [redux] #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: celo-integration-rebase-13.1
Choose a base branch
from
Open

Refactor code for readability [redux] #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
131c993
Refactor code for readability
Ayiga Apr 18, 2025
f125272
Attempt to fix issue with refactor on linux
Ayiga Jun 26, 2025
d522613
Remove duplicate import
Ayiga Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions espresso/environment/3_2_espresso_deterministic_state_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"github.com/ethereum-optimism/optimism/op-node/rollup/derive"
"github.com/ethereum/go-ethereum/accounts/abi/bind"
"github.com/ethereum/go-ethereum/common/hexutil"
"github.com/ethereum/go-ethereum/core/types"
geth_types "github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/crypto"
"github.com/ethereum/go-ethereum/log"
Expand Down Expand Up @@ -237,8 +236,7 @@ func createEspressoTransaction(transactionString string, chainID *big.Int, batch
}

// espressoTransactionDataSkippingUnmarshal extract the L1 info deposit from Espresso transaction without checking whether the unmarshal could work
func espressoTransactionDataSkippingUnmarshal(transactionString string) (*types.Transaction, error) {

func espressoTransactionDataSkippingUnmarshal(transactionString string) (*geth_types.Transaction, error) {
bufData, err := hexutil.Decode(transactionString)
if err != nil {
return nil, fmt.Errorf("failed to decode Espresso transaction in the test: %w", err)
Expand Down
Loading
Loading