IA1.2 Generate dockers for services #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenkeyao
requested review from
Ancient123,
dailinsubjam,
philippecamacho and
QuentinI
shenkeyao
commented
Jun 20, 2025
| @@ -0,0 +1,112 @@ | |||
| # OP Stack Dockerfile, simplified from ops/docker/op-stack-go/Dockerfile | |||
There was a problem hiding this comment.
@Ancient123 Following the pattern in op-stack-go/Dockerfile, I used this file for the OP node, batcher, and proposer, instead of creating one Dockerfile for one service--is this okay?
|
Will the other services (Espresso node, Caff node) be implemented in another PR? |
| mv "$GETH_DIR/geth" /usr/local/bin/geth && \ | ||
| rm -rf geth.tar.gz "$GETH_DIR" && \ | ||
| chmod +x /usr/local/bin/geth | ||
|
|
There was a problem hiding this comment.
We should check the hash GETH_SHA here.
There was a problem hiding this comment.
Oh, we do! It's located around 10+ lines above, the command starting from GETH_SHA=.
There was a problem hiding this comment.
Right, but this variable GETH_SHA does not seem to be used anywhere? Should not we compute the hash of the tar.gz file against GETH_SHA or something similar?
|
|
||
| # Rust builder for Espresso crypto libraries | ||
| FROM --platform=$BUILDPLATFORM rust:1.84.1-alpine3.20 AS rust-builder | ||
| ARG ESPRESSO_NETWORK_GO_VER=0.0.34 |
There was a problem hiding this comment.
Add a TODO to check the hash of the espresso go library when we switch to the new one. cc @dailinsubjam
shenkeyao
commented
Jun 23, 2025
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:8545"] | ||
| interval: 3s | ||
| timeout: 2s | ||
| retries: 40 | ||
| build: | ||
| context: ../ops/docker/deployment-utils | ||
| context: ./dockerfiles/l1-geth | ||
| image: l1-geth:espresso | ||
| volumes: | ||
| - ../config/l1-genesis-devnet.json:/l1-genesis-devnet.json:ro |
There was a problem hiding this comment.
Pasting @Ancient123's comment from Slack:
when doing mounts at runtime don't mount individual files. If the file gets rewritten on the host machine, it won't take affect on the docker, because it can hold onto an older handle for the previous file.
Is this expected? |
@philippecamacho The Espresso dev node uses the Espresso pre-built image, so it doesn't need a Dockerfile. The Caff node uses the same target as the OP node does, so we don't need to specify a Dockerfile for it separately. |
@philippecamacho Not expected! I'll investigate this. |
Made a separate task for this issue because it also occurred on the default branch: https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1210618856384949?focus=true. Will fix it in a separate PR. |
Comment on lines
+38
to
+39
| op-geth-init: | ||
| image: us-docker.pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101503.2-rc.3 |
jparr721
reviewed
Jun 25, 2025
| - op-geth-data:/data | ||
| entrypoint: "" | ||
| command: > | ||
| sh -c " |
There was a problem hiding this comment.
This might be really annoying in terraform. I'd recommend checking how arbitrary scripts work in there. Ideally we'd just make this part of the container instead, so we can fork their container and then add this as a setup step (I think).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1210546932882749?focus=true.
This PR:
op-geth-initservice to avoid manual initialization with the genesis file.How to test this PR:
docker compose up --build -dto build.docker compose logs -fto run all services.Docker Composesection inREADME_ESPRESSO.md.