Skip to content

Philippe/fix GitHub action enclave test #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 44 commits into
base: celo-integration-rebase-13.1
Choose a base branch
from
Draft

Philippe/fix GitHub action enclave test #183

wants to merge 44 commits into from

Conversation

philippecamacho
Copy link
Collaborator

@philippecamacho philippecamacho commented Jun 23, 2025 •
edited
Loading

Closes https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1210619362987817?focus=true

This PR:

Attempts to fix the flakiness of the enclave test. It looks like there is some race condition such that the test are run before the enclave image is fully built.

This PR does not:

  • The main change consists of creating a script to run the enclave tests in CI so that we use only one shell to do that.
  • Also the version of nitro-cli is pinpointed to 1.4.2 (even though this was not the source of the current issue)
  • Finally also updated the docker image to a more recent version.

Key places to review:

All changes.

How to test this PR:

Check CI for "Run enclave tests on EC2 instance" job.

  • Issue linked or PR description mentions why this change is necessary.
  • PR description is clear enough for reviewers.
  • Documentation for changes (additions) has been updated (added).
  • If this is a draft it is marked as "draft".

@philippecamacho philippecamacho marked this pull request as draft June 23, 2025 22:34
@philippecamacho
Ensure the steps for running the tests in the enclave are run in sequ…
4f622cd 
…ence.
@philippecamacho
Avoid logic redundancy
f7b3110
@philippecamacho
Refactor running tests in EC2 instance.
5315e10
@philippecamacho
Fix timeout assignation.
fb9452e
@philippecamacho
Checkout the repository inside github actions.
10b678f
@philippecamacho
Put checkout repository as a single step at the beginning.
6ecbb23
@philippecamacho
Pinpoint version of aws-nitro-enclaves-cli
819f28d
@philippecamacho
Fix version nitro cli for installation.
078e647
@philippecamacho
Upgrade image of Espresso node.
eb1c44b
@philippecamacho
Switch to a slower but more reliable build for contracts.
752a3f3
@philippecamacho
Don't build the tests contracts
3e24d27
@philippecamacho
Compile contracts first and then run the tests.
8c23310
@philippecamacho
Fix attempt
186e815
@philippecamacho
Other attempt
61ccafc
@philippecamacho
Fix
2d8c12a
@philippecamacho
Improvements
046ab5b
@philippecamacho
Fix bug ethereum-optimism#4736 of foundry. Faster execution of comman…
5603482 
…ds inside nix shell.
@philippecamacho
Fix call to nix develop
651ab68
@philippecamacho
Fix nix develop command. Add some log message to get the batch authen…
8afed74 
…ticator address.
@philippecamacho
Fix to install svm.
49ef7fe
@philippecamacho
Define cargo in flake.nix in order to be able to install svm.
bfc9d8a
@philippecamacho
Regenerate the bindings for batch authenticator contract.
53e3957
@philippecamacho
Sleep 5s before running the tests.
eab94f6
@philippecamacho
Cachix configuration
66b3afe
@philippecamacho
Echo variable
accdcd8
@philippecamacho
Fix cachix configuration
237ca3f
@philippecamacho
Fix permission issue
97955fb
@philippecamacho
Another fix for cachix
8a8b814
@philippecamacho
Poblate Cachix cache
c4903ab
@philippecamacho philippecamacho force-pushed the philippe/fix-github-action-enclave-test branch 2 times, most recently from 6782daf to 03e881c Compare June 27, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philippecamacho