GH-993 Add freeze and unfreeze player commands #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces FreezeCommand and UnFreezeCommand for freezing and unfreezing players, including support for self and other actions. Adds localized freeze messages in English and Polish, and integrates freeze message sections into the translation system. Took 47 minutes
igoyek
added
the
🚀 EternalCore 2.0
Closed
igoyek
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces freeze and unfreeze commands, which is a great addition. The implementation is solid, with separate logic for self-action and targeting other players, including permission checks and localized messages.
My review includes a few suggestions to improve maintainability and adhere to standard Java conventions. Specifically, I've pointed out areas with duplicated code in both FreezeCommand and UnFreezeCommand that could be refactored into helper methods. I've also noted a class naming convention issue in UnFreezeCommand. Addressing these points will make the code cleaner and easier to manage in the future.
eternalcore-core/src/main/java/com/eternalcode/core/feature/freeze/FreezeCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/freeze/UnFreezeCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/freeze/UnFreezeCommand.java
Show resolved
Hide resolved
Introduced FreezeService interface and its implementation to centralize freeze/unfreeze logic. Added PlayerFreezeEvent and PlayerUnfreezeEvent for event handling. Refactored FreezeCommand and UnfreezeCommand to use FreezeServiceImpl, improving code modularity and event support. Renamed UnFreezeCommand to UnfreezeCommand for consistency. Took 33 minutes
Jakubk15
reviewed
Aug 17, 2025
eternalcore-core/src/main/java/com/eternalcode/core/feature/freeze/FreezeServiceImpl.java
Outdated
Show resolved
Hide resolved
Updated UnfreezeCommand to use freezeServiceImpl.unfreezePlayer instead of freezePlayer with Duration.ZERO for unfreezing logic. This improves code clarity and better reflects the intended operation. Took 2 minutes
P1otrulla
approved these changes
Aug 17, 2025
Deleted FreezeService, FreezeServiceImpl, and related PlayerFreezeEvent and PlayerUnfreezeEvent classes. Refactored FreezeCommand and UnfreezeCommand to directly manipulate player freeze ticks, simplifying the freeze feature and removing event-based architecture. Took 6 minutes
vLuckyyy
approved these changes
Aug 21, 2025
P1otrulla
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this is how it works. I'll add a few minor tweaks, but please share your feedback and suggestions :)
I think splitting the system into two separate commands would be a better approach than creating two subcommands,
/freeze freezeand/freeze unfreeze.Also, instead of following the class @vLuckyyy sent, I replaced the
CommandSenderclass withPlayerto make it easier to send personalized messages for the performer and target.