feat: implement structured request/response logging for all handlers …#416
Merged
Mystery-CLI merged 2 commits intoEthereal-Future:mainfrom Apr 26, 2026
Merged
Conversation
|
@Dami24-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces raw error string responses with a comprehensive, structured logging system across all route handlers. By enhancing our existing requestLogger and standardized error-catching patterns, we now have full visibility into request duration, status codes, and detailed error context.
Changes:
Enhanced Middleware: Updated requestLogger to calculate request latency and log completion status.
Structured Error Catching: Refactored handlers to use logger.error for all 5xx scenarios, ensuring stack traces are preserved internally while keeping client responses clean.
Standardized Metadata: Every log entry now includes method, path, status, and duration_ms.
Security: Verified that logs do not contain PII or sensitive credentials.
Observability Impact:
Debugging: Drastically reduced MTTR (Mean Time To Resolution) by providing structured error context.
Performance: Request duration logging allows for identifying slow-performing endpoints.
Consistency: All routes now follow the same logging schema.
Checklist:
[x] Branch feature/structured-logging-292 created and pushed.
[x] Verified that 500 errors no longer leak raw system messages to the client.
[x] Log output format is valid JSON.
[x] Confirmed requestLogger covers all active routes.
[x] Linked to Issue #292.
closes #292