CATS support #179
Open
CATS support #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
force-pushed
the
feat/newinfra1
branch
3 times, most recently
from
7eb4f00 to
cc7703c
Compare
igorcrevar
force-pushed
the
feat/newinfra1
branch
from
cc7703c to
28ae44c
Compare
igorcrevar
force-pushed
the
feat/newinfra1
branch
from
28ae44c to
0884694
Compare
cli/generateconfigs/params.go
Outdated
| @@ -204,7 +216,7 @@ func (p *generateConfigsParams) validateFlags() error { | |||
| return fmt.Errorf("invalid %s: %s", primeNetworkAddressFlag, p.primeNetworkAddress) | |||
| } | |||
|
|
|||
| if p.primeBlockfrostURL == "" && p.primeSocketPath == "" && p.primeOgmiosURL == "" { | |||
| if p.primeBlockfrostURL == "" && p.primeSocketPath == "" && p.primeOgmiosURL == "" && p.primeCatsURL == "" { | |||
| return fmt.Errorf("specify at least one of: %s, %s, %s", | |||
There was a problem hiding this comment.
return fmt.Errorf("specify at least one of: %s, %s, %s, %s",
primeBlockfrostURLFlag, primeSocketPathFlag, primeOgmiosURLFlag, primeCatsURLFlag)
cli/generateconfigs/params.go
Outdated
| if !common.IsValidNetworkAddress(p.vectorNetworkAddress) { | ||
| return fmt.Errorf("invalid %s: %s", vectorNetworkAddressFlag, p.vectorNetworkAddress) | ||
| } | ||
|
|
||
| if p.vectorBlockfrostURL == "" && p.vectorSocketPath == "" && p.vectorOgmiosURL == "" { | ||
| if p.vectorBlockfrostURL == "" && p.vectorSocketPath == "" && p.vectorOgmiosURL == "" && p.vectorCatsURL == "" { | ||
| return fmt.Errorf("specify at least one of: %s, %s, %s", |
There was a problem hiding this comment.
return fmt.Errorf("specify at least one of: %s, %s, %s, %s",
vectorBlockfrostURLFlag, vectorSocketPathFlag, vectorOgmiosURLFlag, vectorCatsURLFlag)
cli/generateconfigs/params.go
Outdated
| @@ -217,11 +229,15 @@ func (p *generateConfigsParams) validateFlags() error { | |||
| return fmt.Errorf("invalid prime ogmios url: %s", p.primeOgmiosURL) | |||
| } | |||
|
|
|||
| if p.primeCatsURL != "" && !common.IsValidHTTPURL(p.primeCatsURL) { | |||
| return fmt.Errorf("invalid prime cats url: %s", p.primeCatsURL) | |||
There was a problem hiding this comment.
should you also validate cats api key, if cats url is specified?
cli/generateconfigs/params.go
Outdated
| @@ -234,6 +250,10 @@ func (p *generateConfigsParams) validateFlags() error { | |||
| return fmt.Errorf("invalid vector ogmios url: %s", p.vectorOgmiosURL) | |||
| } | |||
|
|
|||
| if p.vectorCatsURL != "" && !common.IsValidHTTPURL(p.vectorCatsURL) { | |||
| return fmt.Errorf("invalid vector cats url: %s", p.vectorCatsURL) | |||
There was a problem hiding this comment.
should you also validate cats api key, if cats url is specified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI RUN: https://github.com/Ethernal-Tech/blade-apex-bridge/actions/runs/11610247253