fix(core): save tab recovery state before disabling it on close - #11621
Open
uadhran wants to merge 1 commit into
Open
fix(core): save tab recovery state before disabling it on close#11621uadhran wants to merge 1 commit into
uadhran wants to merge 1 commit into
Conversation
closeWindow() set tabRecovery.enabled = false and then called saveTabs(), which returns immediately when disabled, so the final snapshot never wrote. Save first, then latch the flag off so teardown still cannot overwrite recovery with an empty tab list. Addresses Eugeny#11593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #11593
Problem
AppService.closeWindow()settabRecovery.enabled = falseand then calledsaveTabs().saveTabs()returns immediately when that flag is off, so the snapshot that is supposed to run on a clean close never wrote. Recovery on the next launch was whatever the last 1s/30s debounce had stored.enabled = falseis still required during teardown:closeAllTabs()destroys tabs and that would otherwise save an empty list over the snapshot.Fix
Save first, then latch the flag off:
saveTabs()is unchanged. If a tab blocks close, recovery is turned back on as before.Verification
Ran the real
saveTabs/closeWindowbodies:[]does not wipe that snapshoteslintonapp.service.tsis clean.