Fix missing translations keys#47
Open
n-goncalves wants to merge 2 commits intoEuro-Office:mainfrom
Open
Conversation
n-goncalves
force-pushed
the
fix-missing-translations-keys
branch
from
6ec1dcb to
77783d2
Compare
Author
|
Due to my inexperience with GitHub Actions and the fact that I had to jump hoops in order to test it properly, it took more time than I expected but it should be ready now. |
Member
|
@n-goncalves Thanks for contributing this and the prior ones. I tidied up the output code from python as well. Could you say what I should do to test this, so I don't make assumptions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing translation in web-apps, follow up of Euro-Office/DocumentServer#35
Will eventually not be needed once a proper way of handling translation is done (Euro-Office/DocumentServer#60), but it's still worth merging this now imo.
This is a draft because I can't get a runner to test my changes in the build.yml workflow