feat: add Ctrl+Alt+H keyboard shortcut to toggle highlight color#50
Open
MarsEB71 wants to merge 1 commit intoEuro-Office:mainfrom
Open
feat: add Ctrl+Alt+H keyboard shortcut to toggle highlight color#50MarsEB71 wants to merge 1 commit intoEuro-Office:mainfrom
MarsEB71 wants to merge 1 commit intoEuro-Office:mainfrom
Conversation
Adds a keyboard shortcut that applies the current highlight color to selected text on first press, and removes the highlight on a second press if the selection's highlight matches the current color. Closes Euro-Office#55 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Not sure if this gets added, I can't decide that unilaterally, however I would give some feedback generally Why IIFE? I see you are using Claude. You can ask it to look at the existing patterns in the file and follow convention. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Alt+Hshortcut to the document editor toolbarHow it works
Reads the highlight state directly from
api.get_TextProps()on each keypress rather than relying on cached button state. Uses_setMarkerColor('transparent')(which callsSetMarkerFormat(true, false)) to remove the highlight — notSetMarkerFormat(false)which only exits painting mode without removing existing highlights.Test plan
Ctrl+Alt+H→ text highlighted in yellowCtrl+Alt+H→ highlight removedCtrl+Alt+H→ applies new colorCtrl+Alt+H→ no crashCloses #55
🤖 Generated with Claude Code