add previews #966
Merged
add previews #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Preview available
|
cybit
approved these changes
Jan 20, 2025
| name: Run preview | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| PREVIEW_HOSTNAME: ep-preview.click |
There was a problem hiding this comment.
Could we have this as an environment variable please? Makes it reusable for others.
Suggested change
| PREVIEW_HOSTNAME: ep-preview.click | |
| PREVIEW_HOSTNAME: ${{ vars.PREVIEW_HOSTNAME }} |
There was a problem hiding this comment.
Good point! - but I'm going to keep it as-is for now, because there are other things in that GHA that are enviornment-specific, so might be better to just have a separate commit/PR dealing with all those changes at once. – for example there's a separate deployment hostname (static.ep).
Separately it's probably a good idea to structure it as separate build/preview/deploy steps, so could be done as part of that change. Currently deploy/preview share a lot of logic that can be put in a separate "build" step.
Remove the extra dot that was added just to trigger the build Co-authored-by: Cyril Bitterich <[email protected]>
Co-authored-by: Cyril Bitterich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.