Add Postgresql compatibility to the framework#1194
Open
alexandre-janniaux wants to merge 4 commits intoEvarisk:developfrom
Open
Add Postgresql compatibility to the framework#1194alexandre-janniaux wants to merge 4 commits intoEvarisk:developfrom
alexandre-janniaux wants to merge 4 commits intoEvarisk:developfrom
Conversation
Quoting with `` is non-standard (only mysql) and useless here. We don't
need to quote, but if we needed to, it would be possible to quote with
double quote ("") in a standard way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request fixes a few PostgreSQL incompatibilities that I found on the Saturne framework when setting up Digiquali.
The main point here is changing strings in SQL, so as to use the standard single-quoting instead of the mysql double-quoting.
On the migration side there is also backtick-quoting for identifiers that is mysql-specific, the standard way being double-quoting.