Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include previous left out changes into kubernetes PR #45

Merged
merged 31 commits into from
Jan 24, 2025

Conversation

raunakab
Copy link
Collaborator

@raunakab raunakab commented Jan 22, 2025

Overview

In the kubernetes PR, some changes were left out:

  • regex searching when running daft list
  • tests
  • updates to ssh-ing
  • small updates to config-file-parsing logic

This PR aims to merge those changes into the original Kubernetes PR so that that PR can be merged into master without any features missing.

@raunakab raunakab changed the base branch from master to k8s January 22, 2025 00:28
@raunakab raunakab requested a review from jessie-young January 22, 2025 00:28
@raunakab
Copy link
Collaborator Author

@jessie-young, one thing to note is that I've moved all template and .py files to the root-level assets directory. I think it makes more sense here.

I've also created a new macro, asset!, which can be used to immediately include files from that directory right away.

@raunakab
Copy link
Collaborator Author

@jessie-young, I've also added some (very basic) tests for ensuring that daft init and daft check works for the kubernetes changes that you've proposed.

src/main.rs Outdated Show resolved Hide resolved
jessie-young
jessie-young previously approved these changes Jan 22, 2025
Base automatically changed from k8s to master January 23, 2025 05:42
@raunakab raunakab dismissed jessie-young’s stale review January 23, 2025 05:42

The base branch was changed.

jessie-young
jessie-young previously approved these changes Jan 24, 2025
@raunakab raunakab dismissed jessie-young’s stale review January 24, 2025 21:08

The merge-base changed after approval.

@raunakab raunakab requested a review from jessie-young January 24, 2025 21:08
@jessie-young jessie-young merged commit 7e73181 into master Jan 24, 2025
1 check passed
@jessie-young jessie-young deleted the k8s-2 branch January 24, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants