-
Notifications
You must be signed in to change notification settings - Fork 90
Fix Portraits.xml
reloading in unintended scenarios
#919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Portraits.xml
reloading in unintended scenarios
#919
Conversation
Portraits.xml
reloading in unintended scenarios
Since this is a detail that we all missed in the first pr, and requires a separate fix because it was not found until later, I believe it's worthy to be referenced in some way in the added code, specifically why those scenes should be excluded and for what reason. |
My first attempt with just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes on my end, I confirm that before applying the changes, the unexpected reloading of portraits appears in F1-F3 and F5 scenarios, but I couldn't replicate it with the Debug Map.
This PR fixes the unexpected reloading in F1-F3 and F5 scenarios.
Reverted the |
The pull request was approved and entered the 3-day last-call window. |
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
let's go |
Introduced by #890, portraits are reloaded on any scene change. This causes the portraits to reload in unintended scenarios, like reloading the map via F5, opening the Debug Map, or hitting any of the hardcoded F1-F3 binds.
This PR fixes this unintended behavior. Tested locally and it works.