Skip to content

revert: "refactor(cli)!: rename all skills and agents to consistent ce- prefix" (#503)#599

Closed
tmchow wants to merge 1 commit intomainfrom
tmchow/revert-pr-503
Closed

revert: "refactor(cli)!: rename all skills and agents to consistent ce- prefix" (#503)#599
tmchow wants to merge 1 commit intomainfrom
tmchow/revert-pr-503

Conversation

@tmchow
Copy link
Copy Markdown
Collaborator

@tmchow tmchow commented Apr 18, 2026

Summary

Critical merge instructions

When squash-merging, paste the Release-As: footers into the squash-commit message on GitHub. The default squash flow drops PR bodies, which is exactly how #583 failed and required the follow-up #585. The commit message must include:

Release-As: [email protected]
Release-As: [email protected]

After merge

  • Verify release-please PR chore: release main #596 regenerates with 2.69.0 (not 3.0.0) for cli and compound-engineering.
  • If the regenerated release PR still lists a BREAKING CHANGES section (the original ! commit is still in history), hand-edit the release PR body to drop it before merging.

Test plan

  • bun test
  • bun run release:validate

🤖 Generated with Claude Code

…e- prefix (#503)"

This reverts commit 5c0ec91.

The rename landed before the work was ready. Reverting so it can be
continued on the original feature branch and reopened as a new PR.

The `!` marker on #503 caused release-please PR #596 to propose 3.0.0.
The `Release-As:` footers below pin the linked cli/compound-engineering
bump back to 2.69.0 (reflecting the remaining feat+fixes in that release
window), mirroring the precedent set by #583/#585.

Release-As: [email protected]
Release-As: [email protected]
@tmchow tmchow force-pushed the tmchow/revert-pr-503 branch from 891fab1 to af80bf2 Compare April 18, 2026 22:48
@tmchow tmchow closed this Apr 18, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 891fab1351

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Pass the plan file path from step 2 so ce:review can verify requirements completeness.

5. `/ce-todo-resolve`
5. `/compound-engineering:todo-resolve`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace plugin-qualified slash skill calls with canonical names

In lfg, this plugin-qualified slash call does not resolve through the Codex conversion mapping: transformContentForCodex normalizes /compound-engineering:todo-resolve to compound-engineering-todo-resolve and rewrites it to /prompts:compound-engineering-todo-resolve, but the bundle only generates todo-resolve/test-browser targets. On Codex installs, steps 5–6 therefore point to nonexistent prompts. Use canonical skill names (/todo-resolve, /test-browser) or non-slash wording that the converter can map.

Useful? React with 👍 / 👎.

Comment thread src/parsers/claude.ts
const raw = await readText(file)
const { data, body } = parseFrontmatter(raw, file)
const name = (data.name as string) ?? deriveMarkdownStem(file)
const name = (data.name as string) ?? path.basename(file, ".md")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve legacy .agent.md name normalization

This fallback now keeps the .agent suffix in inferred agent names (foo.agent.md -> foo.agent), which regresses legacy Claude plugins that omit name: frontmatter and rely on filename-derived names. Before this commit, .agent was stripped, so references and downstream conversion names stayed stable (foo). Restoring that normalization avoids silently breaking existing plugin inputs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant