Skip to content

Conversation

@ATimmeh33
Copy link
Collaborator

@ATimmeh33 ATimmeh33 commented Sep 26, 2025

This pull request introduces significant updates to the .NET client library, primarily focused on upgrading to .NET 10, updating package dependencies, and standardizing naming conventions for consistency. The most important changes are grouped below:

.NET Version and Project File Updates:

  • Upgraded target framework to .NET 10 in both Signhost.APIClient and Signhost.APIClient.Tests projects, and expanded supported frameworks to include net10.0, net9.0, net8.0, netstandard2.0, and net462 in Signhost.APIClient.csproj. [1] [2]
  • Updated the NuGet publish workflow in .github/workflows/publish_nuget_package.yml to use .NET 10.
  • Bumped package version to 5.0.0 and updated the referenced EntrustSignhostClientLibrary to version 5.0.0. [1] [2] [3]

Naming and Consistency Improvements:

  • Renamed all instances of SignHostApiClientSettings/SignHostApiRetryClient to SignhostApiClientSettings/SignhostApiRetryClient across source, test, and documentation files for consistency. [1] [2] [3] [4] [5] [6]
  • Updated code comments and XML documentation to reflect the new naming conventions.

Testing Improvements:

  • Enabled previously skipped test cases in SignhostApiRetryClientTests.cs to ensure all retry and exception scenarios are now validated. [1] [2]

@ATimmeh33 ATimmeh33 added this to the SemVer 5.0 milestone Sep 26, 2025
@ATimmeh33 ATimmeh33 force-pushed the fix/remove-skip-ignored-tests branch from 3fc7bb5 to cf7d7da Compare November 21, 2025 12:59
@ATimmeh33 ATimmeh33 changed the title Remove skipped tests Make run skipped tests again once fixed in v5 Nov 21, 2025
@ATimmeh33 ATimmeh33 force-pushed the fix/remove-skip-ignored-tests branch from cf7d7da to b847684 Compare November 21, 2025 18:41
@ATimmeh33 ATimmeh33 changed the title Make run skipped tests again once fixed in v5 v5 Release of Polly wrapper Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants