fix(qwen3_5): shard ViT frames across CP ranks#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates Qwen3.5 ViT frame parallel dispatch so CP ranks are symmetric sources:
Why
The previous implementation made cp_rank=0 the only source and cp_rank>0 pure receivers, then used CP all_reduce as a broadcast. That creates source/receiver autograd graph asymmetry. It works for some qwen3_5 video cases but can deadlock in more complex wrappers such as aero_realtime with SP + ViT frame parallel: cp_rank=0 remains in backward while cp_rank>0 reaches grad clipping.
This keeps the same global dp×cp load balancing but removes cp source/receiver asymmetry.
Validation