SOF-7644: rewrite RuntimeItemsMixin #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JobContextMixin, | ||
| WorkflowContextMixin, | ||
| }; | ||
| export { JobContextPickKeysForMixin, WorkflowContextPickKeysForMixin }; |
There was a problem hiding this comment.
We should move these to wode too
There was a problem hiding this comment.
I noticed that we use both of them in web-app only. Do we even need to store it somewhere outside the web-app?
There was a problem hiding this comment.
We can remove these classes and pass context to render functions directly
| } | ||
| }; | ||
| } | ||
| export { RuntimeItemsMixin, ItemKey }; |
There was a problem hiding this comment.
For runtime items, we should have the same approach as with context providers - in Ade we can declare them, and in Wode implement
There was a problem hiding this comment.
Need a discussion about this one
timurbazhirov
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.