Skip to content

Refactoring #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Refactoring #4

wants to merge 14 commits into from

Conversation

ramazansakin
Copy link

  • Lombok integration
  • SonarLint issues fixed
  • README up

@szantopeter
Copy link
Member

@ramazansakin thanks for the PR, looks good, but Travis CI fails to build it. Seems like the JDK is too old. Could you try updating

.travis.yaml

to something like

jdk: openjdk10

and see if it compiles?

@ramazansakin
Copy link
Author

@szantopeter ok , I 'll update soon.

@szantopeter
Copy link
Member

@ramazansakin have you had a chance to look into this?

@ramazansakin
Copy link
Author

@ramazansakin have you had a chance to look into this?

Not yet @szantopeter, so bussy, if you can , please.

Thx

@ramazansakin
Copy link
Author

Hi @szantopeter,

So sorry for last answer but I tried a few times to build via travis but I couldnt get a success build.
Can you try it on my repo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramazansakin @szantopeter