Removed WindowsForms dependency for NativeAOT #802
Merged
+778
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time registrations out of Integration.NativeAOT.
Implemented NativeWindow using Win32 API
Implemented minimal LogDisplay using Win32 API, removed WindowsForms dependency
Added a RibbonController to ExcelDna.TestAOT project.
Implemented support for custom ribbon images using Win32 API
govert
reviewed
Oct 5, 2025
|
|
||
| // Marshal to .NET, then call .Application | ||
| object obj = ComInterop.Util.TypeAdapter.GetObject(pUnk); | ||
| Marshal.Release(pUnk); |
There was a problem hiding this comment.
Why can we skip the Release here? It seems we end up calling Marshal.GetObjectForIUnknown which increments the reference count.
There was a problem hiding this comment.
As I understand,
The reference count will be decremented when the runtime performs garbage collection on the managed object that represents the COM object.
In our case it will be decremented on line 510
finally
{
ComInterop.Util.TypeAdapter.ReleaseObject(obj);
}Calling Marshal.Release(pUnk) manually will over decrement the reference count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.