Skip to content

Commit

Permalink
Addressing PR Comments: removing delete and apply after some discussion
Browse files Browse the repository at this point in the history
  • Loading branch information
Manisha4 committed Feb 11, 2025
1 parent eb2aed1 commit e80a9d1
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions protos/feast/registry/RegistryServer.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,8 @@ service RegistryServer{
rpc ListFeatureViews (ListFeatureViewsRequest) returns (ListFeatureViewsResponse) {}

// SortedFeatureView RPCs
rpc ApplySortedFeatureView (ApplySortedFeatureViewRequest) returns (google.protobuf.Empty) {}
rpc GetSortedFeatureView (GetSortedFeatureViewRequest) returns (feast.core.SortedFeatureView) {}
rpc ListSortedFeatureViews (ListSortedFeatureViewsRequest) returns (ListSortedFeatureViewsResponse) {}
rpc DeleteSortedFeatureView (DeleteSortedFeatureViewRequest) returns (google.protobuf.Empty) {}

// StreamFeatureView RPCs
rpc GetStreamFeatureView (GetStreamFeatureViewRequest) returns (feast.core.StreamFeatureView) {}
Expand Down Expand Up @@ -288,12 +286,6 @@ message ListOnDemandFeatureViewsResponse {

// SortedFeatureView for range queries

message ApplySortedFeatureViewRequest {
feast.core.SortedFeatureView sorted_feature_view = 1;
string project = 2;
bool commit = 3;
}

message GetSortedFeatureViewRequest {
string name = 1;
string project = 2;
Expand All @@ -310,12 +302,6 @@ message ListSortedFeatureViewsResponse {
repeated feast.core.SortedFeatureView sorted_feature_views = 1;
}

message DeleteSortedFeatureViewRequest {
string name = 1;
string project = 2;
bool commit = 3;
}

// FeatureServices

message ApplyFeatureServiceRequest {
Expand Down

0 comments on commit e80a9d1

Please sign in to comment.