fix: Update ScyllaDB required dependencies for compression #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXPEbdodla
changed the title
zabarn
reviewed
Feb 11, 2025
| @@ -115,12 +115,14 @@ | |||
|
|
|||
| CASSANDRA_REQUIRED = [ | |||
| "cassandra-driver>=3.24.0,<4", | |||
| "lz4", | |||
There was a problem hiding this comment.
This will save storage space and costs related to that, but can it potentially increase retrieval latencies?
There was a problem hiding this comment.
All our tests used anaconda image and these dependencies are installed automatically. With switching from anaconda, these needs to be explicitly added.
There was a problem hiding this comment.
Oh so we were already using compression then?
There was a problem hiding this comment.
Yes. With latest Dataproc images, we loose those dependencies.
zabarn
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc