feat: Adding Python classes for new Feature View type SortedFeatureView #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manisha4
changed the title
piket
reviewed
Feb 14, 2025
| tags=tags, | ||
| owner=owner, | ||
| ) | ||
| self.sort_keys = sort_keys or [] |
There was a problem hiding this comment.
Feature view does some validation in the init for entites like making sure the value types match with it's cooresponding feature. We should probably do similar with sort key here. Also ensure we don't have sort key-entity key overlap.
piket
reviewed
Feb 14, 2025
| join_keys=[DUMMY_ENTITY_ID], | ||
| ) | ||
|
|
||
| ONLINE_STORE_TAG_SUFFIX = "online_store_" |
There was a problem hiding this comment.
This isn't needed, same with the one in SortedFeatureView. It's already a constant defined in feature_view.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding Python classes for new Feature View type SortedFeatureView