Skip to content

ProposalPolice hides comments from the assigned C+ / reviewers on Help Wanted issues #99101

Description

@MelvinBot

ProposalPolice™ (rewritten in #97199, merged 2026-08-19) is minimizing comments from C+ contributors and issue assignees, treating their coordination comments as SPAM.

Example: On #97159 it collapsed two comments as minimizedReason: spam:

  • shubham1206agra (assignee/C+), comment 5356254546: "@QichenZhu Would you like to take over here? Or propose a solution"
  • QichenZhu, comment 5356324187: "@shubham1206agra, I don't have a solution yet. If you don't mind, I can take over here and review"

It then posted a template-nag warning: #97159 (comment)

Root cause

The workflow (.github/workflows/proposalPolice.yml) only exempts Expensify employees, via Expensify/expensify-expensify team membership. C+ contributors and the issue's assignee are not exempt, so their comments run through the checks. Comments that don't match the proposal template get an LLM intent call; per prompts/proposalPolice/botActions.ts, SPAM is defined as "claims or bids for the job without offering any technical content," and the examples in prompts/proposalPolice/commentIntentExamples.ts don't cover assignee/reviewer coordination (asking someone to take over, offering to review). Those comments superficially resemble a no-technical-content job claim and are misclassified as SPAM, then collapsed via minimizeComment.

Suggested fix

  • Exempt the issue's current assignee(s) and C+ reviewers from ProposalPolice the same way employees are exempted, and/or
  • Teach the intent classifier that takeover/review coordination is NOT_AN_ATTEMPT rather than SPAM.

Affected comments should be un-minimized.

Reported in Slack.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions