feat: Add attendees field to unreported expenses by MrMuzyk · Pull Request #74699 · Expensify/App

MrMuzyk · 2025-11-10T12:52:36Z

Explanation of Change

Updated the condition to display attendees field on unreported expenses

Fixed Issues

$ #72235

PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Tracked Expenses

Prerequisites for default workspace:

enable rules, enable Attendee tracking inside rules

User with no workspace / User with several non-default workspaces

Go to selfDM
Go to an expense
Verify that the attendees field is NOT displayed

User with a default workspace / only one non-default workspace

Go to selfDM
Go to an expense
Verify that the attendees field is displayed if the attendees rule is enabled on the workspace
Verify that you can change the field value and no errors are displayed
Go back to the selfDM
Click "Submit to someone" under the expense you've just visited
Choose a workspace
Verify that the value is set to the default attendees field value for the chosen workspace (if it's not enabled in rules, it should not be displayed)

Creating a tracked expense

User with no workspace / User with several non-default workspaces

Go to selfDM
Click Composer + -> Create expense
On the Confirmation step, verify that the attendees field is NOT displayed

User with a default workspace / only one non-default workspace

Go to selfDM
Click Composer + -> Create expense
On the Confirmation step, verify that the attendees field is displayed (if the Attendee tracking is enabled in rules)
Verify that the value is set to the default attendees field value for the workspace (default/only one non-default)
Submit the expense
Go to the newly created expense
Verify that the attendees field is set to the value you selected during the creation of the expense

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

attendees.mp4

codecov · 2025-11-10T13:03:47Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...es/iou/request/step/IOURequestStepConfirmation.tsx	`47.85% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`69.39% <95.65%> (+0.31%)`	⬆️
...pages/iou/request/step/IOURequestStepAttendees.tsx	`0.00% <0.00%> (ø)`
... and 2 files with indirect coverage changes

melvin-bot · 2025-11-10T14:41:05Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-11-10T15:03:03Z

BUG: Attendee should have a default value of self.

Steps:

disable the attendees on default workspace.
Create a tracked expense.
Enable the attendees on the workspace.
Check the attendee field on tracked expense.

As attendees can not be null, we should have owner of the expense as attendee.

MrMuzyk · 2025-11-10T15:07:58Z

BUG: Attendee should have a default value of self.

If you find any bugs please let me know the reproduction steps to it too :)

parasharrajat · 2025-11-10T15:14:26Z

Updated.

trjExpensify

Core PR for a #whatsnext project 👍

…35-unreported-expenses-attendees-field

parasharrajat · 2025-11-13T08:56:29Z

Note

Because we decided to hide the attendee(cc: @cristipaval) field on the unreported expense when disabled, we need to add a check on the confirm page to see whether the attendee is disabled on unreported. If so, do not set the value from unreported attendee field to the confirm page. Or, we can just keep that field visible until the user clears the values on the unreported expense.

user can set the values on attendee field on unreported.
user then disabled attendee field on default workspace.
Now, if we submit that unreported to a worspace which has attendee enabled, the old values of attendee from unreported expense will be set on the confirm page which is misleading.

parasharrajat · 2025-11-13T16:25:09Z

BUG: Not able to deselect the value during submit to someone.

13.11.2025_21.54.17_REC.mp4

…35-unreported-expenses-attendees-field

MrMuzyk · 2025-11-14T11:42:36Z

BUG: Attendee should have a default value of self.

We've agreed on slack that this is expected and we'll leave it like that (at least for now)

BUG: Not able to deselect the value during submit to someone.

Just pushed a fix for it. It looks to be working properly now. Thanks for the help @parasharrajat :)

parasharrajat · 2025-11-14T12:04:35Z

Retesting it now.

parasharrajat · 2025-11-14T13:04:35Z

@MrMuzyk Looks like the problem is not solved yet completely.

I can still see both values selected on the attendee selector page even after deselecting them first then going back to attendee selector. Check from 0.31 seconds to the last.

14.11.2025_18.31.17_REC.mp4

parasharrajat · 2025-11-17T07:37:54Z

+        updatedTransaction.comment = {
+            ...updatedTransaction.comment,
+            attendees: transactionChanges.attendees,
+        };


Why did we decide to update this?

To correctly update attendees. attendees are also nested within comment field

I don't know whether we need this. There was no bug in this logic before this PR. And if we are updating both attendees and modifiedAttendees, then what is the user of having modifiedAttendees`

It fixes this scenario:

Steps:

You create an expense add 2 attendee.

Go offline.

Edit the attendee on created expense.

Try to edit again.

Check the selected users on the attendee page.

This method (getUpdatedTransaction) receives transactionChanges as one of the arguments. When comment.attendees are changed on the transaction this method receives attendees (via param mentioned before) that are not nested inside the comment and updates modifiedAttendees instead.

This method is only fired upon editing expense and so far I wasn't able to find anything broken after this change

…35-unreported-expenses-attendees-field

parasharrajat · 2025-11-19T09:12:12Z

@MrMuzyk Can you please fix these checks?

parasharrajat · 2025-11-19T09:25:44Z

BUG: This system message changes after receiving data from the backend.

This is the same for workspace expenses as well.

Looks like the backend does not recognize that attendees are already set on the tracked expense. cc: @cristipaval

19.11.2025_14.52.20_REC.mp4

parasharrajat · 2025-11-19T09:32:35Z

Screenshots

🔲 iOS / native

19.11.2025_16.18.59_REC.mp4

🔲 iOS / Safari

19.11.2025_16.14.37_REC.mp4

🔲 MacOS / Chrome

19.11.2025_14.59.48_REC.mp4

🔲 Android / Chrome

19.11.2025_16.11.19_REC.mp4

🔲 Android / native

19.11.2025_16.08.34_REC.mp4

parasharrajat · 2025-11-19T09:34:28Z

Notes:

Based on our discussions.

For old tracked expenses, the Attendee field will not have any default selected value.
If a tracked expense has attendees and then we disable attendees on the default workspace, the attendees field will not show in self DM expense even though it has values for the attendee field.

cc: @cristipaval @MrMuzyk

…35-unreported-expenses-attendees-field

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

MrMuzyk · 2025-11-19T11:35:23Z

@parasharrajat TS is failing on main too, everything else has now passed

melvin-bot · 2025-11-19T11:51:18Z

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

cristipaval · 2025-11-19T11:51:36Z

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

unrelated

OSBotify · 2025-11-19T16:36:21Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.61-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-21T12:05:10Z

🚀 Deployed to production by https://github.com/grgia in version: 9.2.61-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: Add attendees field to unreported expenses

dbdcb98

melvin-bot Bot assigned MrMuzyk Nov 10, 2025

MrMuzyk marked this pull request as ready for review November 10, 2025 14:40

MrMuzyk requested review from a team as code owners November 10, 2025 14:40

melvin-bot Bot requested review from parasharrajat and removed request for a team November 10, 2025 14:41

melvin-bot Bot requested review from trjExpensify and removed request for a team November 10, 2025 14:41

trjExpensify previously approved these changes Nov 10, 2025

View reviewed changes

MrMuzyk added 5 commits November 12, 2025 09:44

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

6bee5b8

…35-unreported-expenses-attendees-field

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

22e31b8

…35-unreported-expenses-attendees-field

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

291325c

…35-unreported-expenses-attendees-field

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

4454681

…35-unreported-expenses-attendees-field

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

149ff6d

…35-unreported-expenses-attendees-field

MrMuzyk added 2 commits November 14, 2025 09:23

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

8660d61

…35-unreported-expenses-attendees-field

fix: return original attendees

96d2063

MrMuzyk dismissed trjExpensify’s stale review via 96d2063 November 14, 2025 11:34

MrMuzyk added 2 commits November 14, 2025 14:11

fix: use original attendees on attendees page

db6f901

fix: correctly update transaction

579a690

fix: linter

67de080

parasharrajat reviewed Nov 17, 2025

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

f4b553c

…35-unreported-expenses-attendees-field

Merge branch 'main' of https://github.com/Expensify/App into feat/722…

f9c9311

…35-unreported-expenses-attendees-field

parasharrajat approved these changes Nov 19, 2025

View reviewed changes

melvin-bot Bot requested a review from cristipaval November 19, 2025 10:53

parasharrajat reviewed Nov 19, 2025

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated

fix: duplicated icons

cc86091

cristipaval approved these changes Nov 19, 2025

View reviewed changes

cristipaval merged commit 21b0f9b into Expensify:main Nov 19, 2025
26 of 27 checks passed

melvin-bot Bot added the Emergency label Nov 19, 2025

cristipaval removed the Emergency label Nov 19, 2025

OSBotify mentioned this pull request Nov 19, 2025

Deploy Checklist: New Expensify 2025-11-19 #75561

Closed

57 tasks

This was referenced Nov 20, 2025

[$250] Expense - System message changes from "changed the attendees to.." to "set the attendees to.." #75653

Open

[RCA #74699] Expense - Attendee field is cleared after relogin #75678

Closed

grgia mentioned this pull request Nov 20, 2025

[CP Staging] Revert "feat: Add attendees field to unreported expenses" #75692

Merged

melvin-bot Bot mentioned this pull request Nov 21, 2025

[$250][Unreported] Add the Attendees to the unreported expenses #72235

Closed

Uh oh!

Conversation

MrMuzyk commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Nov 10, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Nov 10, 2025

Uh oh!

parasharrajat commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrMuzyk commented Nov 10, 2025

Uh oh!

parasharrajat commented Nov 10, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Nov 13, 2025

Uh oh!

parasharrajat commented Nov 13, 2025

Uh oh!

MrMuzyk commented Nov 14, 2025

Uh oh!

parasharrajat commented Nov 14, 2025

Uh oh!

parasharrajat commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

MrMuzyk Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

MrMuzyk Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Nov 19, 2025

Uh oh!

parasharrajat commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat commented Nov 19, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Uh oh!

MrMuzyk commented Nov 19, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Nov 19, 2025

Uh oh!

cristipaval commented Nov 19, 2025

Uh oh!

OSBotify commented Nov 19, 2025

MrMuzyk commented Nov 10, 2025 •

edited

Loading

codecov Bot commented Nov 10, 2025 •

edited by github-actions Bot

Loading

parasharrajat commented Nov 10, 2025 •

edited

Loading

parasharrajat commented Nov 14, 2025 •

edited

Loading

parasharrajat commented Nov 19, 2025 •

edited

Loading

parasharrajat commented Nov 19, 2025 •

edited

Loading