Skip to content

fix: error when assigning Expensify card to phone number#81267

Open
daledah wants to merge 14 commits into
Expensify:mainfrom
daledah:fix/80874
Open

fix: error when assigning Expensify card to phone number#81267
daledah wants to merge 14 commits into
Expensify:mainfrom
daledah:fix/80874

Conversation

@daledah

@daledah daledah commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #80874
PROPOSAL: #80874 (comment)

Tests

Precondition:

  • Workspace is set up with Expensify card feature.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Click Issue card.
  4. On cardholder step, enter a phone number (60128323983), select the phone number and click Invite.
  5. Complete the rest of the steps and reach confirm page.
  6. On confirm page, click Issue card.
  7. Enter magic code.
  8. Verify that: The card will be assigned successfully.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-m.eb.mov
MacOS: Chrome / Safari
web.mov

@daledah
daledah marked this pull request as ready for review February 3, 2026 07:29
@daledah
daledah requested review from a team as code owners February 3, 2026 07:29
@melvin-bot
melvin-bot Bot requested a review from parasharrajat February 3, 2026 07:29
@melvin-bot

melvin-bot Bot commented Feb 3, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team February 3, 2026 07:29
@codecov

codecov Bot commented Feb 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/Card.ts 0.00% <0.00%> (ø)
... and 14 files with indirect coverage changes

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm whether we can input formatted phone number like we can on other pages like invite member or create chat?

@parasharrajat

Copy link
Copy Markdown
Member

bump...

@daledah

daledah commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

checking now

@parasharrajat

Copy link
Copy Markdown
Member

Also, does it handle country code, etc.? Please check all.

@daledah

daledah commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

I think this appears to be a back-end bug with the AddMembersToWorkspace API. Although we can chat with that phone number, adding that phone number to the workspace as a member results in an error.

bug-resize.mp4
web-resize.mp4

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good product polish

@parasharrajat

Copy link
Copy Markdown
Member

I just tested and it seems to be working just fine @daledah

@parasharrajat

Copy link
Copy Markdown
Member

Bump @daledah

@daledah

daledah commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

I just tested and it seems to be working just fine @daledah

@parasharrajat Please try with +44 20 7946 0958 phone number

bug-resize.mp4

@parasharrajat

parasharrajat commented Feb 19, 2026

Copy link
Copy Markdown
Member

+44 20 7946 0958

Is this format valid? Maybe the number is also not valid.

@daledah

daledah commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

Can you confirm whether we can input formatted phone number like we can on other pages like invite member or create chat?

@parasharrajat I can start a chat room with this phone number

Screen.Recording.2026-02-19.at.10.32.30.mov

@parasharrajat

parasharrajat commented Feb 19, 2026

Copy link
Copy Markdown
Member

Let me check this internally. But we can try with a different number for now.

@daledah

daledah commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

But we can try with a different number for now.

I tested with different numbers and it's working fine

@daledah

daledah commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

Let me check this internally. But we can try with a different number for now.

@parasharrajat any updates here?

Comment thread src/libs/actions/Card.ts
@parasharrajat

Copy link
Copy Markdown
Member

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

@parasharrajat

Copy link
Copy Markdown
Member

Still getting the error. @daledah

08.03.2026_13.08.31_REC.mp4

@parasharrajat

Copy link
Copy Markdown
Member

I noticed that number is added successfully as the member to the workspace but issueing card fails.

@daledah

daledah commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author
bug-resize.mp4

@parasharrajat It seems like this is a back-end error. I tried again with the number here and it showed the error: Uses parent account cannot be set to true without setting a parent card holder.

@parasharrajat

Copy link
Copy Markdown
Member

Can you tag the engineer on the issue and mention this backend issue so that we can get that solved or discussed? Without that, we can't consider this issue completed.

@daledah

daledah commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

@puneetlath I tried to create a new Expensify card and got the error Uses parent account cannot be set to true without setting a parent card holder. Could you please check the CreateAdminIssuedVirtualCard API in the backend to see what is happening here?

bug-resize.mp4

In addition, there is another bug here: I can create a chat room with the number +44 20 7946 0958, but I get an error when adding that number to the workspace.

bug-resize.mp4

@daledah

daledah commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

@puneetlath friendly bump on this comment

@parasharrajat

Copy link
Copy Markdown
Member

@daledah You can use the issue for this.

@puneetlath

Copy link
Copy Markdown
Contributor

Sorry for the delay. @daledah what account are you using to add the Expensify Card? Can you do it again and give me the email address and requestID so that I can look into the logs.

@daledah

daledah commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

I tried to create a new Expensify card and got the error Uses parent account cannot be set to true without setting a parent card holder. Could you please check the CreateAdminIssuedVirtualCard API in the backend to see what is happening here?

  1. requestID: "9deb014178cecf4c-SJC"
  2. account: "daleda261+qbo@gmail.com"
  3. assigneeEmail: "+60128323983@expensify.sms"
  4. API: CreateAdminIssuedVirtualCard
bug-resize.mp4

In addition, there is another bug here: I can create a chat room with the number +44 20 7946 0958, but I get an error when adding that number to the workspace.

  1. requestID: "9deb07228c77e2e7-SJC"
  2. account: "daleda261+qbo@gmail.com"
  3. employees: [{"email":"+442079460958@expensify.sms","role":"user"}]
  4. API: AddMembersToWorkspace
bug-resize.mp4

@puneetlath here you are

@parasharrajat

Copy link
Copy Markdown
Member

Bump @puneetlath

@daledah

daledah commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

friendly bump here @puneetlath

@parasharrajat

parasharrajat commented Apr 2, 2026

Copy link
Copy Markdown
Member

Puneet is OOO till 4th. @daledah Please use issue for this discussion.

@parasharrajat

Copy link
Copy Markdown
Member

@puneetlath Can you please check this?

JmillsExpensify
JmillsExpensify previously approved these changes Jun 3, 2026

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShridharGoel

Copy link
Copy Markdown
Contributor

@MelvinBot Summarise the backend bugs discussed here and create an issue in Expensify/Expensify. Also include the details mentioned here.

@MelvinBot

Copy link
Copy Markdown
Contributor

📋 Created backend issue: https://github.com/Expensify/Expensify/issues/658626

It summarizes the two backend bugs discussed here and includes the details from this comment:

Bug 1 — CreateAdminIssuedVirtualCard returns Uses parent account cannot be set to true without setting a parent card holder (Marqeta error) when issuing a card to a phone-number member. The member gets added to the workspace, but the card issuance fails.

Bug 2 — AddMembersToWorkspace errors when adding a phone number (+44 20 7946 0958) that can otherwise be used to start a chat.

I also noted a possibly-related existing BugBot alert reporting the same Marqeta error string on the GetVirtualCard command (referenced in the issue).

@ShridharGoel

Copy link
Copy Markdown
Contributor

I tried to create a new Expensify card and got the error Uses parent account cannot be set to true without setting a parent card holder. Could you please check the CreateAdminIssuedVirtualCard API in the backend to see what is happening here?

Seems like there was a fix deployed on May 27 here (created by @tylerkaraszewski), can you re-test this?

@ShridharGoel

ShridharGoel commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

In addition, there is another bug here: I can create a chat room with the number +44 20 7946 0958, but I get an error when adding that number to the workspace.

I had created a PR here, it should get reviewed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants