fix: error when assigning Expensify card to phone number#81267
fix: error when assigning Expensify card to phone number#81267daledah wants to merge 14 commits into
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
parasharrajat
left a comment
There was a problem hiding this comment.
Can you confirm whether we can input formatted phone number like we can on other pages like invite member or create chat?
|
bump... |
|
checking now |
|
Also, does it handle country code, etc.? Please check all. |
|
I think this appears to be a back-end bug with the bug-resize.mp4web-resize.mp4 |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Good product polish
|
I just tested and it seems to be working just fine @daledah |
|
Bump @daledah |
@parasharrajat Please try with bug-resize.mp4 |
Is this format valid? Maybe the number is also not valid. |
@parasharrajat I can start a chat room with this phone number Screen.Recording.2026-02-19.at.10.32.30.mov |
|
Let me check this internally. But we can try with a different number for now. |
I tested with different numbers and it's working fine |
@parasharrajat any updates here? |
Screenshots🔲 iOS / native🔲 iOS / Safari🔲 MacOS / Chrome🔲 Android / Chrome🔲 Android / native |
|
Still getting the error. @daledah 08.03.2026_13.08.31_REC.mp4 |
|
I noticed that number is added successfully as the member to the workspace but issueing card fails. |
bug-resize.mp4@parasharrajat It seems like this is a back-end error. I tried again with the number here and it showed the error: |
|
Can you tag the engineer on the issue and mention this backend issue so that we can get that solved or discussed? Without that, we can't consider this issue completed. |
|
@puneetlath I tried to create a new Expensify card and got the error bug-resize.mp4In addition, there is another bug here: I can create a chat room with the number bug-resize.mp4 |
|
@puneetlath friendly bump on this comment |
|
@daledah You can use the issue for this. |
|
Sorry for the delay. @daledah what account are you using to add the Expensify Card? Can you do it again and give me the email address and requestID so that I can look into the logs. |
bug-resize.mp4
bug-resize.mp4@puneetlath here you are |
|
Bump @puneetlath |
|
friendly bump here @puneetlath |
|
Puneet is OOO till 4th. @daledah Please use issue for this discussion. |
|
@puneetlath Can you please check this? |
|
@MelvinBot Summarise the backend bugs discussed here and create an issue in Expensify/Expensify. Also include the details mentioned here. |
|
📋 Created backend issue: https://github.com/Expensify/Expensify/issues/658626 It summarizes the two backend bugs discussed here and includes the details from this comment: Bug 1 —
Bug 2 —
I also noted a possibly-related existing BugBot alert reporting the same Marqeta error string on the |
Seems like there was a fix deployed on May 27 here (created by @tylerkaraszewski), can you re-test this? |
I had created a PR here, it should get reviewed soon. |
Explanation of Change
Fixed Issues
$ #80874
PROPOSAL: #80874 (comment)
Tests
Precondition:
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-m.eb.mov
MacOS: Chrome / Safari
web.mov