Fix bugs for selfDM splits feature by ZhenjaHorbach · Pull Request #92055 · Expensify/App

ZhenjaHorbach · 2026-05-29T09:26:39Z

Explanation of Change

Fixed Issues

$ #91874
$ #91876
$ #91879
$ #91907
$ #91913
$ #91917
$ #91920
$ #91918
PROPOSAL:

Tests

#91874

Precondition:

Create two workspaces.
Make personal policy as default policy on OD.

Test:

Open App
Go to self DM
Create a distance expense
Open the expense
Click Rate field
Verify that the workspace selector opens
Close the RHP
Click More > Split
Click on any split
Click Rate field
Verify that rate field on split details page will open workspace selector

#91876

Precondition:

Account has no workspace.

Test:

Open App
Go to self DM.
Create a distance expense.
Open the expense.
Click More > Split > Save.
Open any split.
Click Amount.
Click on the split.
Click Rate.
Click Upgrade > Confirm > Got it, thanks.
Enter rate and save it.
Verify rate list will show workspace rates when the current distance expense uses personal rate.

#91879

Precondition:

Have a workspace.

Test:

Open App
Go to self DM.
Create an expense.
Open the expense.
Click More > Split.
Open any split.
Click Category.
Click Add category button.
Click back button on not here page.
Verify that add category button will open category creation page.

#91907

Test:

Open App
Go to self DM.
Create a manual expense.
Open the expense.
Click More > Split > Save.
Open any split.
Click on the header.
Click Submit it to someone.
Verify that:

If you aren’t a member of a workspace, hide the ‘Submit to someone’ option on Split expenses
If you’re a member of a workspace, filter the ‘Submit to someone’ option to workspaces for split expenses

#91913

Precondition:

Account has a workspace.
Account has Self DM.

Test:

Open App
Navigate to Self DM.
Create a manual expense.
Open the just created expense.
Click on "More" > "Split" > Save splits.
Open one of the splits.
Click on "More" > "Move to Report" > "Create Report"
Return to Self DM.
Right click and delete the remaining split.
Verify that self DM should still be visible after deleting a split on LHN

#91917

Test:

Open App
Open a workspace chat and create a manual expense.
Split the created expense.
Click on one of the split expenses.
Click More → Edit splits.
Select one of the splits and click Remove split.
Click Save.
Verify that the split expense should be removed successfully without displaying the “Hmm... it’s not here” message

#91918

Test:

Open App
Open a workspace chat and create a manual expense.
Split the created expense.
Go offline.
Select one of the split expenses and delete it.
Verify that only the selected split expense should be deleted, and no extra expense should appear while offline

#91920

Precondition:

Account has Self DM.

Test:

Open App
Navigate to Self DM.
Create a manual expense.
Navigate to "Spend" > "Expenses"
Select the just created expense.
Click on dropdown menu > "Split" > Save splits amount.
Select one of the splits.
Verify that after splitting an unreported expense and selecting a split on "Expenses" section, "Total Spend" should display the same amount as the selected split

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

91874.mov

91876.mov

91879.mov

91907.mov

91913.mov

91918.mov

91920.mov

codecov · 2026-05-29T09:37:07Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/PolicyUtils.ts	`77.06% <100.00%> (ø)`
src/libs/actions/IOU/BulkEdit.ts	`84.72% <ø> (ø)`
src/libs/actions/IOU/Split.ts	`72.24% <ø> (ø)`
src/libs/actions/Transaction.ts	`76.31% <100.00%> (+0.55%)`	⬆️
src/pages/inbox/report/ReportActionItem.tsx	`90.69% <ø> (ø)`
src/selectors/Policy.ts	`74.26% <100.00%> (+0.58%)`	⬆️
src/selectors/Transaction.ts	`80.00% <100.00%> (+2.22%)`	⬆️
src/libs/actions/IOU/SplitExpenseItems.ts	`94.73% <85.71%> (+0.01%)`	⬆️
...ox/report/actionContents/ChatActionableButtons.tsx	`80.21% <87.50%> (-0.47%)`	⬇️
src/hooks/useDeleteTransactions.ts	`54.86% <0.00%> (-0.78%)`	⬇️
... and 10 more
... and 6 files with indirect coverage changes

melvin-bot · 2026-06-22T17:14:57Z

@dmkt9 @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-06-22T17:15:07Z

@dmkt9 is a reviewer here

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57e546e7df

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…order for IOURequestStepDistanceRate

ZhenjaHorbach · 2026-07-21T09:06:46Z

Bug: The self-DM header gets stuck in a loading state, and additional split transactions cannot be created from an existing split transaction.

Open the app.

Create a distance expense in your self-DM.

Split it into two transactions.

Move one of the split transactions to a workspace chat.

Open the unreported split transaction.

Tap Amount > Add more splits (keep the total amount unchanged).

Go offline.

Tap Save.

Verify that the self-DM header is stuck in a loading state.

Go back online.

Verify that the action fails.

2026-07-06.14-47-45.mp4

@dmkt9
This issue should be fixed now

dmkt9 · 2026-07-21T10:42:33Z

@ZhenjaHorbach Thanks for the ping! I'll finish my review soon.

lakchote · 2026-07-21T11:25:46Z

@ZhenjaHorbach Thanks for the ping! I'll finish my review soon.

Thank you @dmkt9. Please prioritize this review as it's an important feature

dmkt9 · 2026-07-22T05:20:51Z

+        await Onyx.merge(snapshotKey, {
+            data: {
+                [split1SnapshotKey]: split1TransactionForSnapshot,
+                [split2SnapshotKey]: split2TransactionForSnapshot,
+            },
+            search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},
+        } as unknown as SearchResults);


Suggested change

await Onyx.merge(snapshotKey, {

data: {

[split1SnapshotKey]: split1TransactionForSnapshot,

[split2SnapshotKey]: split2TransactionForSnapshot,

},

search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},

} as unknown as SearchResults);

const snapshotData: SearchResults['data'] = {};

if (split1TransactionForSnapshot) {

snapshotData[split1SnapshotKey] = split1TransactionForSnapshot;

}

if (split2TransactionForSnapshot) {

snapshotData[split2SnapshotKey] = split2TransactionForSnapshot;

}

await Onyx.merge(snapshotKey, {

data: snapshotData,

search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},

});

dmkt9 · 2026-07-22T05:23:20Z

+        await Onyx.merge(snapshotKey, {
+            data: {
+                [workspaceChildSnapshotKey]: workspaceChildTransaction,
+                [selfDMChildSnapshotKey]: selfDMChildTransaction,
+            },
+            search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},
+        } as unknown as SearchResults);


Suggested change

await Onyx.merge(snapshotKey, {

data: {

[workspaceChildSnapshotKey]: workspaceChildTransaction,

[selfDMChildSnapshotKey]: selfDMChildTransaction,

},

search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},

} as unknown as SearchResults);

const snapshotData: SearchResults['data'] = {};

snapshotData[workspaceChildSnapshotKey] = workspaceChildTransaction;

snapshotData[selfDMChildSnapshotKey] = selfDMChildTransaction;

await Onyx.merge(snapshotKey, {

data: snapshotData,

search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},

});

dmkt9 · 2026-07-22T05:24:53Z

+        await Onyx.merge(snapshotKey, {
+            data: {
+                [child1SnapshotKey]: childTransaction1,
+                [child2SnapshotKey]: childTransaction2,
+            },
+            search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},
+        } as unknown as SearchResults);


Suggested change

await Onyx.merge(snapshotKey, {

data: {

[child1SnapshotKey]: childTransaction1,

[child2SnapshotKey]: childTransaction2,

},

search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},

} as unknown as SearchResults);

const snapshotData: SearchResults['data'] = {};

snapshotData[child1SnapshotKey] = childTransaction1;

snapshotData[child2SnapshotKey] = childTransaction2;

await Onyx.merge(snapshotKey, {

data: snapshotData,

search: {type: CONST.SEARCH.DATA_TYPES.EXPENSE, isLoading: false},

});

dmkt9 · 2026-07-22T05:26:15Z

+"../../tests/actions/IOUTest/SplitTest.ts"	"@typescript-eslint/no-unsafe-type-assertion"	23
+"../../tests/actions/IOUTest/TrackExpenseTest.ts"	"@typescript-eslint/no-unsafe-type-assertion"	10


Suggested change

"../../tests/actions/IOUTest/SplitTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 23

"../../tests/actions/IOUTest/TrackExpenseTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 10

"../../tests/actions/IOUTest/SplitTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 20

"../../tests/actions/IOUTest/TrackExpenseTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 2

dmkt9 · 2026-07-22T07:49:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87ae5689f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-22T07:56:23Z

+                const rateFromAnyPolicy = DistanceRequestUtils.getEnabledRateByCustomUnitRateIDFromAnyPolicy(transactionChanges.customUnitRateID, policies);
+                if (rateFromAnyPolicy?.rate) {
+                    updatedMileageRate = rateFromAnyPolicy;


Recompute distance units for fallback mileage rates

When the selected customUnitRateID is only found via the new cross-policy fallback and that rate uses a different unit, the transaction has already stored newDistanceUnit from the wrong/missing policy and skipped the quantity conversion above. The later amount calculation then treats the old quantity as if it were in the fallback rate's unit (for example, 10 mi becomes 10 km when selecting a km rate), so the split amount/merchant are wrong until corrected by the server, and remain wrong offline. Resolve the fallback rate before setting/converting comment.customUnit.distanceUnit, or redo that conversion when rateFromAnyPolicy is used.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-22T07:56:23Z

+            const submitButtons: ActionableItem[] = isSubmit2026BetaEnabled
                ? [
                      prepareSubmitDestinationButton(CONST.IOU.SUBMIT_DESTINATION.FRIEND, 'submitToFriend'),
                      prepareSubmitDestinationButton(CONST.IOU.SUBMIT_DESTINATION.EMPLOYER, 'submitToEmployer'),


Hide the friend destination for split expenses

For Submit 2026 users with at least one workspace, a self-DM split expense still renders the Submit to a friend button here, but split children are now forced into a workspaces-only recipient picker in IOURequestStepParticipants. Tapping this CTA therefore opens an employer/workspace-only flow under a friend label, and if there is a single/default workspace it can submit to that workspace despite the user choosing the friend destination. Build the submit buttons for split expenses with only the employer/workspace destination.

Useful? React with 👍 / 👎.

dmkt9 · 2026-07-22T08:19:35Z

@MelvinBot review

MelvinBot · 2026-07-22T08:36:09Z

🤖 Reviewed this PR (8 self-DM split bug fixes, ~1.4k LOC). No blockers — the logic is sound and well-commented, and I traced the two highest-risk changes (the reverse-split trigger and the navigation-ordering rework in SplitTransactionUpdate) end-to-end. Two edge cases and a few nits worth a look before merge.

Verified correct (highest-risk areas)

updateSplitTransactions is called exactly once on every path of updateSplitTransactionsFromSplitExpensesFlow after being moved into the three navigation branches + fallthrough. No path double-calls or skips it.
The generalized firstIOU → iouActionsToCleanUp loop faithfully replicates the optimistic/success/failure Onyx data per action; the repeated whisper merges are idempotent. Correct fix for the piled-up duplicate IOU actions.
No import cycle from Transaction.ts importing getAllTransactions from ./IOU — IOU/index.ts has no path back to Transaction, and the call is at call-time only.
Removing the [email] deps arg from the useOnyx(..., {selector}) calls is safe — the selector is created inline (new reference each render), so useOnyx recomputes via hasSelectorChanged regardless.
Cross-policy customUnitRateID collisions are not a real risk (13-hex-char IDs), and getEnabledRateByCustomUnitRateIDFromAnyPolicy correctly excludes disabled/P2P rates.

Worth a look before merge

1. ⚠️ Reverse-split guard was loosened — confirm mixed-report children can't occur. SplitTransactionUpdate.ts:241 (and the mirror at :1913) dropped the allChildTransactions.length === originalChildTransactions.length condition. This is intended (it enables the pure-selfDM collapse path), and pure-workspace behavior is unchanged. The only newly-affected scenario is a mixed original whose children live in both a workspace expense report and selfDM/UNREPORTED at once — if that state is reachable, isReverseSplitOperation now fires and the undelete loop would delete all children. I couldn't find a product flow that produces mixed children, so this is low-likelihood, but please confirm it's impossible (or re-guard the mixed case while keeping the pure-selfDM path).

2. ⚠️ Possible distanceUnit / amount unit mismatch in the any-policy rate fallback. In TransactionUtils/index.ts, newDistanceUnit (L727-728) is derived only from policy, but the amount (L745-754) can use the unit from getEnabledRateByCustomUnitRateIDFromAnyPolicy, whose owning policy may use a different unit (mi vs km). Currently unreachable through the shipped UI (the rate list only offers rates owned by the resolved policy, so the fallback never fires there), but if any caller passes a policy that doesn't own the new rate, the stored unit and the amount would disagree. Consider overriding newDistanceUnit from rateFromAnyPolicy.unit when the fallback is used.

Nits (non-blocking)

Merchant currency may not follow the selected rate — in SplitExpenseItems.ts updateSplitExpenseAmountField, when useSplitSelectedRate is true, rate/unit come from splitSelectedRate but the merchant currency still resolves via the original mileageRate (transactionCurrency ?? mileageRate.currency), never splitSelectedRate.currency. Display-only, and transactionCurrency usually wins — but prefer splitSelectedRate.currency when useSplitSelectedRate.
Redundant re-filter — the DELETE-pending filter at SplitTransactionUpdate.ts:1535 is already applied by the caller in SplitExpensePage.tsx:214. Harmless/defensive.
Delete path doesn't pass extraIOUActions — the other caller of this flow, useDeleteTransactions.ts:322, defaults extraIOUActions to [], so the "clean up all duplicate IOU actions" fix only applies from the SplitExpensePage save path. Likely fine (the delete path isn't a split→revert→split cycle), but worth confirming.

All CI checks are currently green. Nice test coverage added (SplitTest.ts +806, plus the new ClearSplitTransactionErrorTest.ts and selector tests).

dmkt9 · 2026-07-22T08:47:57Z

#91876
Precondition:

Account has no workspace.

Test:

Open App

Go to self DM.

Create a distance expense.

Open the expense.

Click More > Split > Save.

Open any split.

Click Amount.

Click on the split.

Click Rate.

Click Upgrade > Confirm > Got it, thanks.

Enter rate and save it.

Verify rate list will show workspace rates when the current distance expense uses personal rate.

Next steps: 13. Go offline 14. Select the default rate > Save > Save

We are encountering a bug after selecting the rate and saving split expenses: the amount becomes 0 and the merchant status changes to Pending.

Unfortunately, I can reproduce this bug again.

dmkt9 · 2026-07-22T09:17:36Z

Bug: It looks like the pendingActions weren't cleared.

Open the app.
Navigate to your self-DM.
Create an expense.
Go offline.
Split the expense.
Open one of the split expenses.
Click the Amount field, then select Remove this split expense.
Go online and wait for syncing to complete.
Go offline again.
Verify that the deleted split expense reappears.

2026-07-22.16-11-19.mp4

dmkt9 · 2026-07-22T09:42:44Z

Bug: The self-DM header gets stuck in a loading state, and additional split transactions cannot be created from an existing split transaction.

Open the app.

Create a distance expense in your self-DM.

Split it into two transactions.

Move one of the split transactions to a workspace chat.

Open the unreported split transaction.

Tap Amount > Add more splits (keep the total amount unchanged).

Go offline.

Tap Save.

Verify that the self-DM header is stuck in a loading state.

Go back online.

Verify that the action fails.

This step still occurs on my side. I remember you couldn't reproduce it on your side, but could you please check again? We've had a few bugs in the past that you couldn't reproduce locally, but QA was able to reproduce them.

Verify that the self-DM header is stuck in a loading state.

ZhenjaHorbach · 2026-07-22T09:54:11Z

#91876
Precondition:

Account has no workspace.

Test:

Open App

Go to self DM.

Create a distance expense.

Open the expense.

Click More > Split > Save.

Open any split.

Click Amount.

Click on the split.

Click Rate.

Click Upgrade > Confirm > Got it, thanks.

Enter rate and save it.

Verify rate list will show workspace rates when the current distance expense uses personal rate.

Next steps: 13. Go offline 14. Select the default rate > Save > Save
We are encountering a bug after selecting the rate and saving split expenses: the amount becomes 0 and the merchant status changes to Pending.

Unfortunately, I can reproduce this bug again.

Can't reproduce
Can you record a video?

ZhenjaHorbach · 2026-07-22T09:56:06Z

Bug: The self-DM header gets stuck in a loading state, and additional split transactions cannot be created from an existing split transaction.

Open the app.

Create a distance expense in your self-DM.

Split it into two transactions.

Move one of the split transactions to a workspace chat.

Open the unreported split transaction.

Tap Amount > Add more splits (keep the total amount unchanged).

Go offline.

Tap Save.

Verify that the self-DM header is stuck in a loading state.

Go back online.

Verify that the action fails.

This step still occurs on my side. I remember you couldn't reproduce it on your side, but could you please check again? We've had a few bugs in the past that you couldn't reproduce locally, but QA was able to reproduce them.

Verify that the self-DM header is stuck in a loading state.

The same
Works well for me

2026-07-22.11.56.51.mov

dmkt9 · 2026-07-22T09:56:17Z

Can't reproduce Can you record a video?

I recorded a video in my earlier comment.

dmkt9 · 2026-07-22T09:58:16Z

@ZhenjaHorbach Which browser are you using? I'm using Chrome/Edge on Linux, and I can reproduce them consistently.

ZhenjaHorbach · 2026-07-22T09:58:59Z

@ZhenjaHorbach Which browser are you using? I'm using Chrome/Edge on Linux, and I can reproduce them consistently.

Chrome on macOs

ZhenjaHorbach · 2026-07-22T10:02:08Z

Plus
I don't think it makes sense to spend a lot of time on edge cases and issues that are difficult to reproduce
If they do appear in the future,
We can fix them as a follow-up and not block this PR

dmkt9 · 2026-07-22T10:05:13Z

Plus I don't think it makes sense to spend a lot of time on edge cases and issues that are difficult to reproduce If they do appear in the future, We can fix them as a follow-up and not block this PR

OK, that makes sense to me as well.

ZhenjaHorbach · 2026-07-22T10:06:01Z

Bug: It looks like the pendingActions weren't cleared.

Open the app.

Navigate to your self-DM.

Create an expense.

Go offline.

Split the expense.

Open one of the split expenses.

Click the Amount field, then select Remove this split expense.

Go online and wait for syncing to complete.

Go offline again.

Verify that the deleted split expense reappears.

2026-07-22.16-11-19.mp4

Also works well for me

2026-07-22.12.04.48.mov

dmkt9 · 2026-07-22T10:11:21Z

Also works well for me

Did you follow my steps?

ZhenjaHorbach · 2026-07-22T10:28:07Z

Also works well for me

Did you follow my steps?

But okay
Sorry for confusing
Now can reproduce
Will fix soon

ZhenjaHorbach · 2026-07-22T12:10:32Z

Bug: It looks like the pendingActions weren't cleared.

Open the app.

Navigate to your self-DM.

Create an expense.

Go offline.

Split the expense.

Open one of the split expenses.

Click the Amount field, then select Remove this split expense.

Go online and wait for syncing to complete.

Go offline again.

Verify that the deleted split expense reappears.

2026-07-22.16-11-19.mp4

About this issue
Looks like the root cause isn't in the split code: pendingAction only clears via successData and successData for this record is correctly targeted, but it still gets clobbered
Two writes queue offline back-to-back (Transaction_Split, then RevertSplitTransaction). On reconnect the client detects an update-ID gap and routes the split-creation response through OnyxUpdateManager's deferred pipeline instead of applying it immediately
So this is a race between two Onyx update pipelines (deferred gap-recovery vs. immediate apply), not a self-DM-splits bug, and not fixable by adding more successData here
Real fix touches src/libs/actions/OnyxUpdateManager/ which I don't want to touch in this PR 😅
So I think we can fix it in a separate issue

ZhenjaHorbach added 2 commits May 28, 2026 10:15

Merge the first bunch of fixes

7d22b03

Fix conflicts

0600e38

melvin-bot Bot assigned ZhenjaHorbach May 29, 2026

ZhenjaHorbach changed the title ~~Fix bugs with self dm splits~~ Fix bugs for self dm splits feature May 29, 2026

ZhenjaHorbach changed the title ~~Fix bugs for self dm splits feature~~ Fix bugs for selfDM splits feature May 29, 2026

ZhenjaHorbach added 2 commits May 29, 2026 12:34

Add fix for 91907

a88c95a

Add fix for 91920

56fc7d1

sobitneupane mentioned this pull request Jun 1, 2026

Split – “Hmm... it’s not here” displayed when removing a split expense #91917

Open

7 tasks

MelvinBot mentioned this pull request Jun 1, 2026

Expense - Unreported split expense cannot be deleted #92231

Closed

7 tasks

ZhenjaHorbach added 7 commits June 4, 2026 14:03

Fix conflicts

db9ac60

Add fix for 91917

b4a8331

Fix conflicts

b865cad

Fix conflicts

12d104c

Refactor code

f5a75fb

Refactor code x2

7477e46

Refactor code x3

57e546e

ZhenjaHorbach marked this pull request as ready for review June 22, 2026 17:14

ZhenjaHorbach requested review from a team as code owners June 22, 2026 17:14

melvin-bot Bot requested review from dmkt9, flaviadefaria and sobitneupane and removed request for a team June 22, 2026 17:14

github-actions Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread src/pages/DynamicReportDetailsPage.tsx Outdated

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceRate.tsx Outdated

Fix comments with new selector for hasWorkspaceToSubmitTo and policy …

8378193

…order for IOURequestStepDistanceRate

ZhenjaHorbach added 6 commits July 14, 2026 11:48

Fix conflicts

d4685ed

Fix lint issues

eeca781

Merge branch 'main' into fix-bugs-with-selfDM-splits

61ebdd4

Fix conflicts

e0c425d

Fix lint issues

7b1ab32

Fix conflicts

87ae568

dmkt9 reviewed Jul 22, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Fix conflicts

c6d9b7e

Fix comments

e9cba9c

		"../../tests/actions/IOUTest/SplitTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 23
		"../../tests/actions/IOUTest/TrackExpenseTest.ts" "@typescript-eslint/no-unsafe-type-assertion" 10

Uh oh!

Conversation

ZhenjaHorbach commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

ZhenjaHorbach commented Jun 22, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ZhenjaHorbach commented Jul 21, 2026

Uh oh!

dmkt9 commented Jul 21, 2026

Uh oh!

lakchote commented Jul 21, 2026

Uh oh!

dmkt9 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

MelvinBot commented Jul 22, 2026

Verified correct (highest-risk areas)

Worth a look before merge

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

ZhenjaHorbach commented Jul 22, 2026

Uh oh!

ZhenjaHorbach commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

dmkt9 commented Jul 22, 2026

Uh oh!

ZhenjaHorbach commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented May 29, 2026 •

edited

Loading

codecov Bot commented May 29, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jul 22, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 22, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 22, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 22, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 22, 2026 •

edited

Loading