Update the policy expensify card table to the new style#93861
Conversation
Introduce the reusable table and row components for the policy Expensify Card list, including sorting, search, selection, and the new table row sentry label.
Replace the FlatList-based card list with WorkspaceExpensifyCardsTable and remove the legacy row and header components.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a4b3e07d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
I think we should just not fix the header so hard. It feels really unnecessary to me.
Not against something like this.
Huge agree. The amount of truncation happening currently is abysmal haha. |
|
Added the reveal button. @dubielzyk-expensify please check it out Screen.Recording.2026-06-18.at.2.26.40.PM.mov |
Fixed Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-23.at.11.22.47.mov |
|
@situchan fixed all reported issues |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
Footer text is cut off on first load footer.mov |
|
@Expensify/design what do we want to do with the footnotes here? Should it always be off screen by default? |
I think that would be nice, but I don't feel strongly. I think it's also fine if they were docked at the bottom of the screen and then moved down as the table grew. But I think we mainly just don't want it right below a short table, if that makes sense. |
|
Ok, I just did what we do on prod today. Screen.Recording.2026-06-26.at.10.31.35.AM.mov |
|
@situchan ready for review again |
|
Looks good to me! |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.21-2 🚀
|
|
Deploy Blocker #94750 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀
Bundle Size Analysis (Sentry): |




Explanation of Change
Migrate the policy Expensify Card list page to the shared
Tablecomponent.Fixed Issues
$ #86212
Tests
Offline tests
N/A
QA Steps
Same as tests