Skip to content

Update the policy expensify card table to the new style#93861

Merged
luacmartins merged 18 commits into
mainfrom
cmartins-ecardTable
Jun 26, 2026
Merged

Update the policy expensify card table to the new style#93861
luacmartins merged 18 commits into
mainfrom
cmartins-ecardTable

Conversation

@luacmartins

@luacmartins luacmartins commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Migrate the policy Expensify Card list page to the shared Table component.

Fixed Issues

$ #86212

Tests

  1. Open a workspace Expensify Card page with issued cards
  2. Confirm balance, remaining limit, and cash back labels render above the table
  3. Confirm cardholder, type, limit type, last four, and limit columns render on wide screens
  4. Tap a row → card details opens
  5. Select multiple cards and confirm bulk Export as CSV still works
  6. With 12+ cards, confirm search and sorting work
  7. Confirm Issue card, Settings, and feed selector still work
  • Verify that no errors appear in the JS console
Screenshot 2026-06-17 at 3 56 39 PM Screenshot 2026-06-17 at 3 56 56 PM

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

Introduce the reusable table and row components for the policy Expensify Card list, including sorting, search, selection, and the new table row sentry label.
Replace the FlatList-based card list with WorkspaceExpensifyCardsTable and remove the legacy row and header components.
@luacmartins luacmartins self-assigned this Jun 17, 2026
@luacmartins luacmartins changed the title Cmartins ecard table Update the policy expensify card table to the new style Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 94.07% <ø> (ø)
src/components/Table/TableBody.tsx 96.55% <100.00%> (+0.55%) ⬆️
...e/expensifyCard/WorkspaceExpensifyCardListPage.tsx 0.00% <0.00%> (ø)
...sifyCardsTable/WorkspaceExpensifyCardsTableRow.tsx 0.00% <0.00%> (ø)
...ents/Tables/WorkspaceExpensifyCardsTable/index.tsx 0.00% <0.00%> (ø)
... and 25 files with indirect coverage changes

@luacmartins
luacmartins marked this pull request as ready for review June 17, 2026 21:54
@luacmartins
luacmartins requested review from a team as code owners June 17, 2026 21:54
@melvin-bot
melvin-bot Bot requested review from Krishna2323, joekaufmanexpensify and situchan and removed request for a team June 17, 2026 21:54
@melvin-bot

melvin-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 17, 2026 21:54
@luacmartins
luacmartins requested a review from a team June 17, 2026 21:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a4b3e07d7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

On mobile, we'd wanna make the card number appear like it does on Company cards. This PR:

CleanShot 2026-06-18 at 13 12 24@2x

What we want:

CleanShot 2026-06-18 at 13 13 03@2x

cc @Expensify/design

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Also due to the big numbers at the top we end up with a huge static area at the top of the screen and we probably wanna shrink this down (I know we're doing a smaller search bar as a follow-up):

CleanShot 2026-06-18 at 13 13 47@2x

Wonder if we need to have a little reveal button for the later stats:

image

Curious what @Expensify/design thinks here too

@dannymcclain

Copy link
Copy Markdown
Contributor

I think we should just not fix the header so hard. It feels really unnecessary to me.

Wonder if we need to have a little reveal button for the later stats:

Not against something like this.

On mobile, we'd wanna make the card number appear like it does on Company cards

Huge agree. The amount of truncation happening currently is abysmal haha.

@luacmartins

Copy link
Copy Markdown
Contributor Author

Added the reveal button. @dubielzyk-expensify please check it out

Screen.Recording.2026-06-18.at.2.26.40.PM.mov

@luacmartins

Copy link
Copy Markdown
Contributor Author

In mobile selection mode, header title should be "Select multiple" and when click back button, escape selection mode.
And when no items selected in selection mode, the button should be "0 selected" dropdown.

Fixed

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-23.at.11.22.47.mov

@luacmartins

Copy link
Copy Markdown
Contributor Author

@situchan fixed all reported issues

@luacmartins
luacmartins requested a review from situchan June 23, 2026 17:23
@situchan

situchan commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
iOS: HybridApp
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov

@situchan

Copy link
Copy Markdown
Contributor

Footer text is cut off on first load

footer.mov

@luacmartins

Copy link
Copy Markdown
Contributor Author

@Expensify/design what do we want to do with the footnotes here? Should it always be off screen by default?

@shawnborton

Copy link
Copy Markdown
Contributor

Should it always be off screen by default?

I think that would be nice, but I don't feel strongly. I think it's also fine if they were docked at the bottom of the screen and then moved down as the table grew. But I think we mainly just don't want it right below a short table, if that makes sense.

@luacmartins

Copy link
Copy Markdown
Contributor Author

Ok, I just did what we do on prod today.

Screen.Recording.2026-06-26.at.10.31.35.AM.mov

@luacmartins

Copy link
Copy Markdown
Contributor Author

@situchan ready for review again

@shawnborton

Copy link
Copy Markdown
Contributor

Looks good to me!

@luacmartins
luacmartins merged commit 7484baa into main Jun 26, 2026
38 checks passed
@luacmartins
luacmartins deleted the cmartins-ecardTable branch June 26, 2026 17:54
@github-actions

Copy link
Copy Markdown
Contributor

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.21-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94750 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants