Skip to content

Add Rillet integration multiple account export pages#95562

Open
s77rt wants to merge 64 commits into
Expensify:mainfrom
s77rt:Rillet-integration-multiple-account-export
Open

Add Rillet integration multiple account export pages#95562
s77rt wants to merge 64 commits into
Expensify:mainfrom
s77rt:Rillet-integration-multiple-account-export

Conversation

@s77rt

@s77rt s77rt commented Jul 8, 2026

Copy link
Copy Markdown
Member

Explanation of Change

Added Rillet-integration multiple account export pages

Fixed Issues

$ #94851
PROPOSAL:

Tests

  • Have a workspace with multiple assigned cards from different feeds (e.g. a Expensify Card and a Company Card)
  • Have Rillet integration connected to workspace
  1. Go to accouting
  2. Click on Export
  3. Verify there is a Configure exporting to multiple accounts toggle
  4. Enable the toggle
  5. Verify two more option rows appeared Card program account and Per-card account
  6. Verify you can update the Card program account for each program
  7. Verify you can clear the custom account for each program
  8. Verify you can update the Per-card account for each card
  9. Verify you can clear the custom account for each card
  10. Go to Company Cards > Card
  11. Verify you can update the custom account from there too (the option is named Rillet per-card account export)
Screen.Recording.2026-07-14.at.9.28.36.PM.mov
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@lakchote lakchote requested review from lakchote and truph01 July 10, 2026 08:17
@s77rt

s77rt commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Split default option

Follow up issue #95950

Remove card account selector page and stale translate

Done!

Update accounting section to match design

Follow up issue #95951

Clear per-card account custom export

FE side this is handled. @lakchote will handle the BE in a follow up (treat an empty string as a indicator to clear the NVPs)

Remove Card reconciliation option (Rillet only)

Done!

@s77rt

s77rt commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Failing tests are for missing translation cc @lakchote please run workflow #95562 (comment)

There are also some lint issues and that I'm handling now...

@s77rt s77rt requested a review from truph01 July 13, 2026 15:57
@s77rt

s77rt commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@truph01 This is good for another review. As for testing you should be able to test everything except clearing the per-card custom account (BE fix here).

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core design doc issues.

Comment thread src/pages/workspace/accounting/utils.tsx
Comment thread src/ROUTES.ts Outdated
@truph01

truph01 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e17f1040a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/CardFeedUtils.ts Outdated
Comment thread src/pages/workspace/accounting/rillet/export/RilletCardAccountCardList.tsx Outdated
Comment thread src/pages/workspace/accounting/utils.tsx
@s77rt

s77rt commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

All what we are missing is the translations. @lakchote Please run workflow #95562 (comment)

@truph01

truph01 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42c0525d55

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +47 to +49
const cardProgramsOfflineFeedbackKeys = [CONST.EXPENSIFY_CARD.BANK, ...Object.values(CONST.COMPANY_CARD.FEED_BANK_NAME)].map(
(program) => `${CONST.RILLET_CONFIG.CARD_PROGRAM_ACCOUNT_PREFIX}${program}`,
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include actual feed keys when tracking Rillet feedback

For numbered/custom feed variants that useCardFeeds can return (for example vcf2), updateRilletCardProgramAccount writes feedback under cardProgramAccount_${feedKey} using that exact feed key. This hard-coded list only subscribes to the base constants, so pending/error state for those feeds will not surface on the Export row (and the parent accounting row mirrors the same pattern), even though the new selector lets users configure those feeds.

Useful? React with 👍 / 👎.

Comment thread src/libs/CardFeedUtils.ts
Comment on lines +481 to +482
const feedDomainID = card.fundID ?? CONST.DEFAULT_MISSING_ID;
const feedWithDomainID = getCardFeedWithDomainID(feedKey, feedDomainID);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the list domain when matching card overrides

Some workspace/company cards in WORKSPACE_CARDS_LIST can be stored without fundID, while the collection key already encodes the domain/feed. In that case this falls back to CONST.DEFAULT_MISSING_ID, builds a bank#-1 key, and drops the card from all custom Rillet export count/pending/error calculations, so users with those cards won't see their per-card overrides or failures on the new Rillet export pages.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants