Skip to content

Render report field name as HTML only when needed #95661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmgraa wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Render report field name as HTML only when needed #95661

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ebfe9d5
render report name as HTML conditionally
jmgraa Jul 8, 2026
8a501ab
render report name as HTML conditionally
jmgraa Jul 14, 2026
0f840ab
Merge remote-tracking branch 'upstream' into jmgraa/ios-native-share-…
jmgraa Jul 15, 2026
37e5fd5
add tests for HTML rendering, title truncation and styling consistency
jmgraa Jul 17, 2026
5394e44
update conditions for rendering HTML titles
jmgraa Jul 17, 2026
32fc032
revert adding tests
jmgraa Jul 17, 2026
aa15fb5
simplify condition for processedPlainTextTitle
jmgraa Jul 20, 2026
57b822a
add explanation comment to shouldRenderAsHTML
jmgraa Jul 20, 2026
98704c0
remove redundant processedPlainTextTitle variable
jmgraa Jul 20, 2026
39e136b
explain plain-text title rendering
jmgraa Jul 20, 2026
f896edb
remove additional comment
jmgraa Jul 20, 2026
a8229ce
preserve Android LTR conversion for plain HTML titles
jmgraa Jul 20, 2026
80e5f14
skip RenderHTML for plain MenuItem titles only
jmgraa Jul 20, 2026
f90083a
Merge remote-tracking branch 'upstream' into jmgraa/ios-native-share-…
jmgraa Jul 20, 2026
f62c78c
revert shouldParseFullTitle condition
jmgraa Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/components/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ type MenuItemBaseProps = ForwardedFSClassProps &
/** The type of brick road indicator to show. */
brickRoadIndicator?: ValueOf<typeof CONST.BRICK_ROAD_INDICATOR_STATUS>;

/** Should render the content in HTML format */
/** Should render the content in HTML format. A title without HTML content is rendered as plain text even when this is set. */
shouldRenderAsHTML?: boolean;

/** Whether or not the text should be escaped */
Comment thread
jmgraa marked this conversation as resolved.
Expand Down Expand Up @@ -752,6 +752,8 @@ function MenuItem({
return Parser.replace(helperText, {shouldEscapeText});
}, [helperText, shouldParseHelperText, shouldEscapeText]);

const shouldRenderTitleAsHTML = shouldRenderAsHTML && !!title && Parser.isHTML(title);

const processedTitle = useMemo(() => {
let titleToWrap = '';
if (shouldRenderAsHTML) {
Expand Down Expand Up @@ -1050,7 +1052,14 @@ function MenuItem({
>
{!!title && (shouldRenderAsHTML || (shouldParseTitle && !!html.length)) && (
<View style={[styles.renderHTMLTitle, styles.textAlignLeft, shouldApplyIconPaddingToHTMLTitle && iconLeftPadding]}>
<RenderHTML html={processedTitle} />
{/* Use Text instead of RenderHTML when the title is plain text.
Titles with shouldRenderAsHTML use baseFontStyle, which differs from combinedTitleTextStyle below.
*/}
{shouldRenderTitleAsHTML || shouldParseTitle ? (
<RenderHTML html={processedTitle} />
) : (
<Text style={styles.webViewStyles.baseFontStyle}>{convertToLTR(Parser.htmlToText(processedTitle))}</Text>

@truph01 truph01 Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary htmlToText round-trip on plain text

When shouldRenderTitleAsHTML is false, processedTitle wraps the title in <comment> tags only for Parser.htmlToText to strip them. Could this just use convertToLTR(title ?? '') directly?

@jmgraa jmgraa Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrap-then-strip pattern looks redundant. However, it exists because the processedTitle logic always appends , regardless of whether the output is HTML or plain text. If we remove Parser.htmlToText, the user will see literal "" tags in the text.

The truncation logic in processedTitle is awkward, but refactoring it is out of scope for this PR, so we retain the existing pipeline.

)}
Comment thread
jmgraa marked this conversation as resolved.
</View>
)}
{!shouldRenderAsHTML && !shouldParseTitle && !!title && (
Expand Down
Loading