Add clickable metadata support to embedded Victory bar charts

[inimaga]

Held on:

• https://github.com/Expensify/Web-Expensify/pull/54516
• https://github.com/Expensify/Web-Expensify/pull/54677

Explanation of Change

This PR adds per-point metadata parsing for embedded Victory chart data, preserving label and searchQuery fields and carrying them through the Victory chart renderer context.
Vertical embedded bar charts should now show web hover tooltips from that metadata and navigate to Search when a bar has a searchQuery.

Fixed Issues

$ #92149
PROPOSAL: N/A

Tests

• Verify that no errors appear in the JS console

Automated Tests

Covered by added automated tests

Manual Test

Pre-requisite (Skip to Test Steps if testing in Staging/Prod):

1. Ensure you have AZ/Concierge is setup in dev
2. Checkout and run https://github.com/Expensify/Web-Expensify/pull/54516 in Web-E
3. Checkout and run Add clickable metadata support to embedded Victory bar charts #96065 (current branch) in App and login with a test account

Test Steps:

1. Ensure the selected test account has a bunch of expenses across several months this year. (If not, create some dummy expenses).
2. Start a 1-on-1 DM with Concierge.
3. Ask it something like “Give me a spend bar chart of my monthly expenses for this year.”
4. Wait for the response with an embedded vertical Victory bar chart.
5. On the App PR build, hover a bar.
6. Verify the tooltip appears.
7. Click a bar.
8. Verify it navigates to the corresponding Search results.

Issue.92149.mp4

Offline tests

QA Steps

Same as manual test steps above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../VictoryChartRenderer/BaseVictoryChartRenderer.tsx	0.00% <ø> (ø)
...ryChartRenderer/parsers/processVictoryChartTree.ts	75.00% <100.00%> (+1.78%)	⬆️
...oryChartRenderer/utils/getChartPointMetadataKey.ts	100.00% <100.00%> (ø)
...rs/VictoryChartRenderer/utils/parseRawChartData.ts	100.00% <100.00%> (ø)
src/components/Charts/hooks/useLabelHitTesting.ts	0.00% <0.00%> (ø)
...ctoryChartRenderer/context/VictoryChartContext.tsx	5.55% <0.00%> (ø)
...ictoryChartRenderer/parsers/victorySeriesParser.ts	90.00% <86.36%> (+5.38%)	⬆️
...Renderer/utils/getVictoryBarInteractionGeometry.ts	87.87% <87.87%> (ø)
...ChartRenderer/components/VictoryChartCartesian.tsx	0.00% <0.00%> (ø)
...erer/components/VictoryChartInteractiveContent.tsx	16.66% <16.66%> (ø)
... and 5 more
... and 9 files with indirect coverage changes

[melvin-bot]

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[situchan]

If this requires C+ review, I'll be reviewing this as part of project.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c467b0a5c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[trjExpensify]

What's up with the axis here? On the spend page the values are dynamic based on the data set. This looks like it puts all of the bars below the first data point on the axis?

For the data on hover, why aren't we showing the same data as the Spend page?

CC: @Expensify/design @luacmartins

[shawnborton]

Yeah agree, I would think the y axis would use smaller amounts so the bars would be taller? That feels odd for sure.

[luacmartins]

What's up with the axis here? On the spend page the values are dynamic based on the data set. This looks like it puts all of the bars below the first data point on the axis?

The current instructions adjust the axis dynamically, but they set a $500 minimum. So that's why for small amounts we show it like that. I'm not sure why we have the minimum though, we can probably remove that.

[inimaga]

What's up with the axis here? On the spend page the values are dynamic based on the data set. This looks like it puts all of the bars below the first data point on the axis?
For the data on hover, why aren't we showing the same data as the Spend page?

Both flagged issues have now been fixed. It did need a backend change though, so this PR is on hold till Web-E#54677 gets deployed.

Issue.-.54677.mp4

[trjExpensify]

The current instructions adjust the axis dynamically, but they set a $500 minimum.

Just on these in-line charts? 🤔

[luacmartins]

@trjExpensify Yes. Not sure why.

[trjExpensify]

Weird. The spend page always starts the bottom line of the y-axis on $0 and then the increments are dynamic based on the data set.

[inimaga]

@hoangzinh / @situchan Would either of you be able to review this today?

[github-actions]

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96065.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://96065.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[hoangzinh]

If this requires C+ review, I'll be reviewing this as part of project.

It appears to be part of a project that @situchan is working on.