[CP staging] Revert "Introduce free trial countdown pop-up"#96129
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6a6b575f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -299,9 +299,6 @@ const ONYXKEYS = { | |||
| /** ID associated with the payment card added by the user. */ | |||
| NVP_BILLING_FUND_ID: 'nvp_expensify_billingFundID', | |||
There was a problem hiding this comment.
Removing NVP_DISMISSED_TRIAL_PAYMENT_REMINDER from ONYXKEYS leaves src/libs/ExportOnyxState/common.ts:221 still referencing ONYXKEYS.NVP_DISMISSED_TRIAL_PAYMENT_REMINDER (repo-wide search only finds that remaining use). Any build/typecheck that includes ExportOnyxState now resolves a non-existent ONYXKEYS member, or an undefined entry at runtime if transpiled, so the revert is incomplete; drop that export-state entry too or keep the key until all references are gone.
Useful? React with 👍 / 👎.
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
jasperhuangg
changed the title
[CP staging] Revert "Introduce free trial countdown pop-up" (cherry picked from commit e657e05) (cherry-picked to staging by jasperhuangg)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.34-7 🚀
|
|
🤖 No help site changes required — I did not create a draft docs PR. This PR reverts the "free trial countdown pop-up" ( I reviewed all free-trial and payment-related articles under
Because no article referenced the reverted pop-up and the generic trial/payment-card guidance still holds, there is nothing to update on the help site. @jasperhuangg, if you believe a help article did describe this countdown pop-up and should be reverted too, let me know which one and I'll open a docs PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.35-1 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files under Conclusion: No help site changes are required, so I did not create a draft PR. This PR reverts Expensify/App#84049 ("Introduce free trial countdown pop-up"). All changes are deletions of a frontend-only UI feature — the Why no docs update is needed
Since the reverted behavior isn't reflected in any help article, there's nothing to update or roll back on the docs side. Since there's no linked help site PR, there's nothing further to review here. If you believe an article should have documented this pop-up and needs updating, let me know and I'll take another pass. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.4.35-6 🚀
|
4 participants
Reverts #84049
$ #96077
$ #96069