Skip to content

[CP staging] Revert "Introduce free trial countdown pop-up" #96129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 3 commits into from
Jul 14, 2026
Merged

[CP staging] Revert "Introduce free trial countdown pop-up" #96129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6a6b57
Revert "Introduce free trial countdown pop-up"
jasperhuangg Jul 14, 2026
696ab50
Merge branch 'main' of github.com:Expensify/App into revert-84049-fix…
jasperhuangg Jul 14, 2026
a9b4670
fix: remove reverted NVP_DISMISSED_TRIAL_PAYMENT_REMINDER onyx key ref
jasperhuangg Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion assets/images/product-illustrations/arm_with_card_pos.svg
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6407,11 +6407,6 @@ const CONST = {
},
ONBOARDING_JOINABLE_WORKSPACES_LIMIT: 5,
ACTIONABLE_TRACK_EXPENSE_WHISPER_MESSAGE: 'What would you like to do with this expense?',
TRIAL_REMINDER_VARIANT: {
BASIC: 'basic',
NEAR_END: 'nearEnd',
COUNTDOWN: 'countdown',
},
ONBOARDING_ACCOUNTING_MAPPING,

REPORT_FIELD_TITLE_FIELD_ID: 'text_title',
Expand Down
4 changes: 0 additions & 4 deletions src/GlobalModals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const LazyPopoverReportActionContextMenu = React.lazy(() => import('./pages/inbo
const LazyUpdateAppModal = React.lazy(() => import('./components/UpdateAppModal'));
const LazyScreenShareRequestModal = React.lazy(() => import('./components/ScreenShareRequestModal'));
const LazyProactiveAppReviewModalManager = React.lazy(() => import('./components/ProactiveAppReviewModalManager'));
const LazyTrialPaymentReminderModalManager = React.lazy(() => import('./components/TrialPaymentReminderModalManager'));

// Maximum time (ms) the context menu mount can stay deferred before requestIdleCallback forces it to run,
// guaranteeing mount even if the main thread never becomes idle.
Expand Down Expand Up @@ -69,9 +68,6 @@ function GlobalModals() {
{/* Proactive app review modal shown when user has completed a trigger action */}
<LazyProactiveAppReviewModalManager />
</LazyModalSlot>
<LazyModalSlot>
<LazyTrialPaymentReminderModalManager />
</LazyModalSlot>
<LazyModalSlot>
<LazyScreenShareRequestModal />
</LazyModalSlot>
Expand Down
4 changes: 0 additions & 4 deletions src/ONYXKEYS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,6 @@ const ONYXKEYS = {
/** ID associated with the payment card added by the user. */
NVP_BILLING_FUND_ID: 'nvp_expensify_billingFundID',

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the dangling trial-reminder Onyx export key

Removing NVP_DISMISSED_TRIAL_PAYMENT_REMINDER from ONYXKEYS leaves src/libs/ExportOnyxState/common.ts:221 still referencing ONYXKEYS.NVP_DISMISSED_TRIAL_PAYMENT_REMINDER (repo-wide search only finds that remaining use). Any build/typecheck that includes ExportOnyxState now resolves a non-existent ONYXKEYS member, or an undefined entry at runtime if transpiled, so the revert is incomplete; drop that export-state entry too or keep the key until all references are gone.

Useful? React with 👍 / 👎.


/** ISO timestamp of the last time the trial payment reminder was dismissed */
NVP_DISMISSED_TRIAL_PAYMENT_REMINDER: 'nvp_dismissedTrialPaymentReminder',

/** The user's freebie credits balance (in cents). */
NVP_PRIVATE_FREEBIE_CREDITS: 'nvp_private_freebieCredits',

Expand Down Expand Up @@ -1658,7 +1655,6 @@ type OnyxValuesMapping = {
[ONYXKEYS.NVP_FIRST_DAY_FREE_TRIAL]: string;
[ONYXKEYS.NVP_LAST_DAY_FREE_TRIAL]: string;
[ONYXKEYS.NVP_BILLING_FUND_ID]: number;
[ONYXKEYS.NVP_DISMISSED_TRIAL_PAYMENT_REMINDER]: string;
[ONYXKEYS.NVP_PRIVATE_FREEBIE_CREDITS]: number;
[ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED]: number;
[ONYXKEYS.NVP_PRIVATE_OWNER_BILLING_GRACE_PERIOD_END]: number;
Expand Down
2 changes: 0 additions & 2 deletions src/components/Icon/chunks/illustrations.chunk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ import RunOutOfTime from '@assets/images/multifactorAuthentication/running-out-o
import PendingTravel from '@assets/images/pending-travel.svg';
// Product Illustrations
import Abracadabra from '@assets/images/product-illustrations/abracadabra.svg';
import ArmWithCardPos from '@assets/images/product-illustrations/arm_with_card_pos.svg';
import BigVault from '@assets/images/product-illustrations/big-vault.svg';
import BrokenCompanyCardBankConnection from '@assets/images/product-illustrations/broken-humpty-dumpty.svg';
import BrokenMagnifyingGlass from '@assets/images/product-illustrations/broken-magnifying-glass.svg';
Expand Down Expand Up @@ -271,7 +270,6 @@ const Illustrations = {

// Product Illustrations
Abracadabra,
ArmWithCardPos,
BigVault,
BrokenCompanyCardBankConnection,
BrokenMagnifyingGlass,
Expand Down
99 changes: 0 additions & 99 deletions src/components/TrialPaymentReminderModal.tsx
View file
Open in desktop

This file was deleted.

54 changes: 0 additions & 54 deletions src/components/TrialPaymentReminderModalManager.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading