Remove hard coded ellipsis#96199
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
heyjennahay and
mananjadhav
and removed request for
a team
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
a team and
daledah
and removed request for
a team
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index ce8725f08f4..4c0cd55cbed 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7652,7 +7652,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Blockiert' : 'Erlaubt'} ${shownCount > 1 ? 'Kategorien' : 'Kategorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} weitere` : ''}`,
- defaultRuleSummary: 'Kategorien einschließlich Erwachsenendienste, Geldautomaten, Glücksspiel und ...',
+ defaultRuleSummary: 'Kategorien einschließlich Erotikdienstleistungen, Geldautomaten, Glücksspiel und Geldüberweisungen',
findRule: 'Regel suchen',
defaultSection: 'Standard',
customRulesSection: 'Benutzerdefinierte Regeln',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index dce452bdee1..4f3f90e1734 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7545,7 +7545,7 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Transporte y transporte compartido',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Agencias de viajes',
},
- defaultRuleSummary: 'Categorías que incluyen servicios para adultos, cajeros automáticos, juegos de azar y...',
+ defaultRuleSummary: 'Categorías que incluyen servicios para adultos, cajeros automáticos, juegos de azar y transferencias de dinero',
findRule: 'Buscar regla',
defaultSection: 'Predeterminado',
customRulesSection: 'Reglas personalizadas',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index d0ac1cb8c4c..9aaef668b19 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7681,7 +7681,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqué' : 'Autorisé'} ${shownCount > 1 ? 'catégories' : 'catégorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} de plus` : ''}`,
- defaultRuleSummary: 'Catégories incluant les services pour adultes, les distributeurs automatiques, les jeux d’argent, et...',
+ defaultRuleSummary: 'Catégories incluant les services pour adultes, les distributeurs automatiques, les jeux d’argent et les transferts d’argent',
findRule: 'Trouver une règle',
defaultSection: 'Par défaut',
customRulesSection: 'Règles personnalisées',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 47ec8c074e5..5bdeb2a21ec 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7635,7 +7635,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloccato' : 'Consentito'} ${shownCount > 1 ? 'categorie' : 'categoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} in più` : ''}`,
- defaultRuleSummary: 'Categorie che includono servizi per adulti, sportelli bancomat, gioco d’azzardo e...',
+ defaultRuleSummary: 'Categorie che includono servizi per adulti, bancomat, gioco d’azzardo e trasferimenti di denaro',
findRule: 'Trova regola',
defaultSection: 'Predefinito',
customRulesSection: 'Regole personalizzate',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 552e0481806..87462798984 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7541,7 +7541,7 @@ ${reportName}`,
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'ブロック済み' : '許可されています'} ${shownCount > 1 ? 'カテゴリ' : 'カテゴリ'}: ${categories}${hiddenCount > 0 ? `、ほか +${hiddenCount} 件` : ''}`,
- defaultRuleSummary: 'アダルトサービス、ATM、ギャンブルなどを含むカテゴリ',
+ defaultRuleSummary: 'アダルトサービス、ATM、ギャンブル、送金を含むカテゴリ',
findRule: 'ルールを検索',
defaultSection: 'デフォルト',
customRulesSection: 'カスタムルール',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 7f95f9f65c6..1e6128f9a95 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7613,7 +7613,7 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Geblokkeerd' : 'Toegestaan'} ${shownCount > 1 ? 'categorieën' : 'categorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} meer` : ''}`,
- defaultRuleSummary: 'Categorieën zoals erotische diensten, geldautomaten, gokken en...',
+ defaultRuleSummary: 'Categorieën zoals diensten voor volwassenen, geldautomaten, gokken en geldoverdrachten',
findRule: 'Regel zoeken',
defaultSection: 'Standaard',
customRulesSection: 'Aangepaste regels',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 771f57498ed..b86ec97003c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7593,7 +7593,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Zablokowane' : 'Dozwolone'} ${shownCount > 1 ? 'kategorie' : 'kategoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} więcej` : ''}`,
- defaultRuleSummary: 'Kategorie obejmujące usługi dla dorosłych, bankomaty, hazard i...',
+ defaultRuleSummary: 'Kategorie obejmujące usługi dla dorosłych, bankomaty, hazard i przekazy pieniężne',
findRule: 'Znajdź regułę',
defaultSection: 'Domyślne',
customRulesSection: 'Własne zasady',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index c16a4129876..8ad639ba920 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7606,7 +7606,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqueado' : 'Permitido'} ${shownCount > 1 ? 'categorias' : 'categoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} mais` : ''}`,
- defaultRuleSummary: 'Categorias incluindo serviços adultos, caixas eletrônicos, jogos de azar e...',
+ defaultRuleSummary: 'Categorias incluindo serviços adultos, caixas eletrônicos, jogos de azar e transferências de dinheiro',
findRule: 'Encontrar regra',
defaultSection: 'Padrão',
customRulesSection: 'Regras personalizadas',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index da8cf21b0e6..5bd11c30c39 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7391,7 +7391,7 @@ ${reportName}`,
action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
}) =>
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? '已屏蔽' : '已允许'} ${shownCount > 1 ? '类别' : '类别'}: ${categories}${hiddenCount > 0 ? `，还有 +${hiddenCount} 个` : ''}`,
- defaultRuleSummary: '包括成人服务、ATM、赌博等在内的类别',
+ defaultRuleSummary: '包括成人服务、ATM、赌博和转账在内的类别',
findRule: '查找规则',
defaultSection: '默认',
customRulesSection: '自定义规则',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
luacmartins
approved these changes
Jul 15, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Removes hard coded ellipsis from the workspace spend rules default rule tab
Fixed Issues
$ #96197
Tests
Offline tests
N/A
QA Steps
Same
PR Author Checklist
Reviewer Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).Avatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos