Allow clearing the Default Vendor by re-selecting it (CC/DC export only) by Beamanator · Pull Request #96227 · Expensify/App

Beamanator · 2026-07-15T22:51:49Z

Explanation of Change

On accounting integrations where the non-reimbursable export destination is Credit Card / Debit Card, blank Default Vendor has a defined UX — expenses without a vendor export to "Credit Card Misc". But once a Default Vendor is set on those export paths, there's no way to clear it: tapping the currently-selected row is a silent no-op that just navigates back. This blocks vendor-matching CC beta testers who need to reset workspaces between test scenarios.

This change lets the user re-tap the currently-selected vendor to clear it, but only on the CC/DC export paths:

QBO shared QuickbooksNonReimbursableVendorSelectPage: gated on configKey === 'nonReimbursableCreditCardDefaultVendor'. The Bill entry point of the same shared page keeps its existing behavior.
Sage Intacct DynamicSageIntacctDefaultVendorPage: gated on settingName === CONST.SAGE_INTACCT_CONFIG.NON_REIMBURSABLE_CREDIT_CARD_VENDOR. The Bill and reimbursable variants keep their existing behavior.

Vendor Bill export paths are intentionally out of scope — blank on those integrations means "use the report submitter" and is set by disabling the parent Default Vendor toggle rather than by clearing the vendor from this list. QBD, NetSuite, and Certinia only support Vendor Bill export, so they're not touched.

Xero doesn't have a Default Vendor selector today; it will be added as part of the broader vendor-matching project.

Backend note: sending CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE ('NONE') for QBO's nonReimbursableCreditCardDefaultVendor field has precedent via the bulk updateQuickbooksCompanyCardExpenseAccount path. Sage Intacct's NON_REIMBURSABLE_CREDIT_CARD_VENDOR command being able to persist an empty string should be verified on the backend before merging.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/659748
PROPOSAL: https://github.com/Expensify/Expensify/issues/659748#issuecomment-4985966633

Tests

QBO — Credit Card export path:

Open a workspace with QBO connected.
Under the QBO Export settings, set the non-reimbursable export destination to Credit Card (or Debit Card).
Enable the Default Vendor toggle and pick any vendor.
Open the Default Vendor row again and tap the currently-selected vendor.
Verify the vendor is now cleared — the row shows no default vendor and re-opening the selector shows no row highlighted.

QBO — Vendor Bill export path (regression check, should NOT toggle):

Same workspace, change the non-reimbursable export destination to Vendor Bill.
Enable the Default Vendor toggle and pick a vendor.
Open the Default Vendor row and tap the currently-selected vendor.
Verify tapping the currently-selected vendor does nothing — the vendor stays selected.

Sage Intacct — Credit Card Charge path:

Open a workspace with Sage Intacct connected.
Set the non-reimbursable export type to Credit Card Charge.
Pick any Default Vendor.
Re-open the Default Vendor list and tap the currently-selected vendor.
Verify the vendor is now cleared.

Sage Intacct — Vendor Bill / Reimbursable paths (regression check, should NOT toggle):

Same workspace, switch to non-reimbursable Vendor Bill (or open the reimbursable Default Vendor selector).
Pick a Default Vendor and then tap it again in the selector.
Verify the vendor stays selected — no clear.

Verify that no errors appear in the JS console

Offline tests

On QBO with CC/DC export, set a Default Vendor while online.
Turn off network connection.
Tap the currently-selected vendor.
Verify the row updates optimistically to a cleared state.
Turn network back on and verify the change persists.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Tapping the currently-selected vendor on any accounting integration's Default Vendor selector now clears it. Previously the guarded update call skipped this case, leaving no path to unset the field from the UI. QBO and QBD send CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE; Sage Intacct, Certinia, and NetSuite send an empty string. Fixes Expensify/Expensify#659748

melvin-bot · 2026-07-15T22:51:54Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-15T22:56:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...port/QuickbooksNonReimbursableVendorSelectPage.tsx	`0.00% <0.00%> (ø)`
...cct/export/DynamicSageIntacctDefaultVendorPage.tsx	`0.00% <0.00%> (ø)`
... and 128 files with indirect coverage changes

Beamanator · 2026-07-15T22:59:55Z

@codex review

chatgpt-codex-connector · 2026-07-15T23:05:05Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: f037fc3d1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Beamanator · 2026-07-15T23:46:45Z

@codex review

chatgpt-codex-connector · 2026-07-15T23:50:30Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 9c7dcfdcec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1 · 2026-07-16T05:56:57Z

Hi @Beamanator, let me know when this is ready for review, thank you!

Beamanator · 2026-07-16T13:50:53Z

Sounds good @Eskalifer1 - actually this requires being added to the vendorMatching beta and setting up an accounting integration, have you done that before? :D If not i can ask someone else!

Eskalifer1 · 2026-07-16T13:53:27Z

Oh, i hadn't done it before. Feel free to reassign. Thank you!

Beamanator · 2026-07-16T14:22:24Z

Thanks for the quick response @Eskalifer1 , and thanks @mkhutornyi for volunteering to take over!

trjExpensify

Hm, not sure about this. For export with vendor bills, you must have a vendor chosen for export. So I don't know why we'd let you deselect a vendor to have no vendor selected. CC: @heyjennahay

Beamanator · 2026-07-16T14:40:31Z

minnnnteresting - @trjExpensify i'll tag you in slack here :D https://expensify.slack.com/archives/C03TME82F/p1784118449309309

mkhutornyi · 2026-07-16T14:47:50Z

-            if (row.value !== nonReimbursableBillDefaultVendor) {
-                updateQuickbooksDesktopNonReimbursableBillDefaultVendor(policyID, row.value, nonReimbursableBillDefaultVendor);
-            }
+            const newValue = row.value === nonReimbursableBillDefaultVendor ? (CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE as string) : row.value;


as string cast here looks unnecessary.

Beamanator · 2026-07-16T15:04:32Z

@mkhutornyi i'm so sorry, i just asked you to review but can you pause reviewing this one for now? Just will we get @trjExpensify 's comment(s) sorted 🙏 [we're discussing in slack]

heyjennahay · 2026-07-16T15:07:03Z

My understanding of the way it works:

if you have vendor bills selected as your export method and you leave the default vendor disabled (i.e. blank) then your export will use the report submitter as the vendor
if you have credit card or debit card selected as your export method and you leave the default vendor blank then your expenses without a vendor will export to Credit Card Misc

So the system is actually built to handle no vendor being set for both export types and in fact, default vendor is disabled by default for vendor bills

Blank default vendor has a defined UX only on the CC/DC export path (falls back to "Credit Card Misc"). For Vendor Bill export, blank falls back to the report submitter and is set by disabling the parent toggle, so re-tapping to clear is out of scope. Per team alignment on https://expensify.slack.com/archives/C03TME82F/p1784118449309309, the PR now covers: - QBO shared page: gated on configKey === 'nonReimbursableCreditCardDefaultVendor' - Sage Intacct: gated on settingName === NON_REIMBURSABLE_CREDIT_CARD_VENDOR Reverts the QBD, NetSuite, and Certinia changes — those integrations only support Vendor Bill export, not CC/DC.

Beamanator · 2026-07-16T16:59:21Z

@codex review

chatgpt-codex-connector · 2026-07-16T17:03:34Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: c429fc2e87

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-07-16T17:06:02Z

@MelvinBot review

MelvinBot · 2026-07-16T17:11:32Z

🤖 Reviewed the diff. The change is clean, minimal, and correctly scoped to the CC/DC export paths. One backend item to confirm before merge, plus a minor consistency nit.

✅ Looks good

The gating is right. Re-tapping the selected row is a no-op elsewhere and only clears on the CC/DC path — QBO via configKey === 'nonReimbursableCreditCardDefaultVendor', Sage via settingName === NON_REIMBURSABLE_CREDIT_CARD_VENDOR.
The QBO 'NONE' clear value has a confirmed frontend precedent: the parent company-card page already sends INTEGRATION_ENTITY_MAP_TYPES.NONE to clear the bill default vendor via the toggle.
Cleared state renders correctly. After clearing, the display does vendors.find(v => v.id === currentVendor) — 'NONE' / '' match no vendor, so the row shows blank and re-opening the selector highlights nothing. Good.

⚠️ Confirm before merge — Sage Intacct empty-string persistence

The Sage clear sends vendorID: ''. The optimistic Onyx update handles '' fine, but unlike the QBO 'NONE' path there's no existing precedent for sending an empty vendor ID here. As the PR description already notes, the UpdateSageIntacctNonReimbursableExpensesCreditCardChargeExportDefaultVendor command needs to be confirmed to actually persist the cleared value on the backend — otherwise it'll optimistically clear and then silently revert on successData. Worth verifying against the API before this ships.

💡 Minor — use the constant for the QBO gate

The Sage side compares against a CONST, but the QBO side uses a bare string literal 'nonReimbursableCreditCardDefaultVendor'. There's already a matching constant — CONST.QUICKBOOKS_CONFIG.NON_REIMBURSABLE_CREDIT_CARD_DEFAULT_VENDOR — so using it keeps the two integrations consistent and stays in sync if the key is ever renamed. It's type-checked today, so this is low priority.

💡 Optional — tests

No unit tests were added (checklist item is unchecked). The three-way branch (clear on gated path / set / no-op on ungated path) is exactly the kind of logic a small test would lock in against regressions.

Beamanator requested review from a team as code owners July 15, 2026 22:51

melvin-bot Bot assigned Beamanator Jul 15, 2026

melvin-bot Bot requested a review from Eskalifer1 July 15, 2026 22:51

melvin-bot Bot requested review from trjExpensify and removed request for a team July 15, 2026 22:51

github-actions Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/certinia/export/CertiniaDefaultVendorPage.tsx Outdated

github-actions Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/intacct/export/DynamicSageIntacctDefaultVendorPage.tsx Outdated

github-actions Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread ...pages/workspace/accounting/netsuite/export/DynamicNetSuiteExportExpensesVendorSelectPage.tsx Outdated

Beamanator added the InternalQA This pull request required internal QA label Jul 15, 2026

Replace bare '' with named CLEAR_DEFAULT_VENDOR constant

9c7dcfd

Beamanator requested review from mkhutornyi and removed request for Eskalifer1 July 16, 2026 14:22

trjExpensify reviewed Jul 16, 2026

View reviewed changes

mkhutornyi reviewed Jul 16, 2026

View reviewed changes

Beamanator changed the title ~~Allow clearing the Default Vendor by re-selecting it~~ Allow clearing the Default Vendor by re-selecting it (CC/DC export only) Jul 16, 2026

Uh oh!

Conversation

Beamanator commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

codecov Bot commented Jul 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Beamanator commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 15, 2026

Uh oh!

Beamanator commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 15, 2026

Uh oh!

Eskalifer1 commented Jul 16, 2026

Uh oh!

Beamanator commented Jul 16, 2026

Uh oh!

Eskalifer1 commented Jul 16, 2026

Uh oh!

Beamanator commented Jul 16, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Jul 16, 2026

Uh oh!

mkhutornyi Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

heyjennahay commented Jul 16, 2026

Uh oh!

Beamanator commented Jul 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 16, 2026

Uh oh!

mkhutornyi commented Jul 16, 2026

Uh oh!

MelvinBot commented Jul 16, 2026

✅ Looks good

⚠️ Confirm before merge — Sage Intacct empty-string persistence

💡 Minor — use the constant for the QBO gate

💡 Optional — tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Beamanator commented Jul 15, 2026 •

edited

Loading

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading

Beamanator commented Jul 16, 2026 •

edited

Loading