[No QA] Updates to ECUK setup docs for formatting and instructions #96438
Conversation
…nd-Manage-the-Expensify-Card-US.md
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@mjasikowski @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f60a8c82e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| After activation, the card is ready to use. | ||
|
|
||
| ## How do I change my PIN? | ||
| For details on how to set, view, change, or unblock an Expensify Card's PIN, see [Manage Your Expensify Card PIN (GBP/EUR Cards Only)](/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN). |
There was a problem hiding this comment.
Point PIN instructions at an existing article
When UK/EU cardholders follow this new PIN-management link, it will 404 because the commit removes the inline PIN FAQ but does not add docs/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN.md or a redirect for that slug; a repo-wide file search only finds this reference and an unrelated chat pin article. Either add the target article/redirect or keep the PIN steps in this page.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
PIN article is being published at the same time: #89154 (
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
This comment has been minimized.
This comment has been minimized.
rafecolton
left a comment
There was a problem hiding this comment.
Approving in case we need to merge and do a follow-up, but I do spot some minor issues
Co-authored-by: Rafe Colton <1058475+rafecolton@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rafe Colton <1058475+rafecolton@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://06a34f51.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.4.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.41-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari