Search - Load categories from all workspaces#96460
Draft
ShridharGoel wants to merge 2 commits into
Draft
Conversation
Use lightweight search data without replacing full category rules or optimistic state. Refs Expensify/Expensify#661264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Load lightweight category data for every workspace only when the Category filter opens. Merge it with full category data already stored in Onyx so category rules and optimistic updates remain unchanged.
This makes categories from non-default workspaces available in the Spend filters without increasing the initial Search response. The new collection contains only the category name and enabled state to keep the response small.
Companion Auth PR: https://github.com/Expensify/Auth/pull/23042
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/661264
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components using that component are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Designlabel or tagged@Expensify/designso the design team can review the changes.mainwas merged into this PR after review, I tested again and verified the expected outcome.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari