[WIP] [No QA] [Performance] Add API.writeWhenReady for deferred optimistic writes#96490
Draft
JakubKorytko wants to merge 1 commit into
Draft
[WIP] [No QA] [Performance] Add API.writeWhenReady for deferred optimistic writes#96490JakubKorytko wants to merge 1 commit into
JakubKorytko wants to merge 1 commit into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
JakubKorytko
force-pushed
the
korytko/api-write-when-ready
branch
from
July 21, 2026 09:18
323b61e to
523c36b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds
API.writeWhenReady(command, params, onyxData, barrier?): it defers a write - including its optimistic Onyx updates - until a readiness signal fires (default: the navigation transition), then delegates to the normalwrite()pipeline, leaving optimistic/success/failure handling, retries, and ordering unchanged. Foundational primitive; no call sites are migrated yet. Includes a safety timeout, an app-background flush, and unit tests.Fixed Issues
$ #96010
PROPOSAL: N/A
Tests
This PR adds an API primitive with no call sites yet, so there is no user-facing flow to exercise; correctness is covered by unit tests.
Offline tests
N/A - no user-facing flow invokes this primitive yet. The deferral and app-background flush behavior (which persists a pending write before the process can be killed) is covered by the unit tests.
QA Steps
[No QA] - no code path invokes
writeWhenReadyyet, so there is nothing to verify on staging. Correctness is covered by the unit tests.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari