Skip to content

Fix Supplier RHP backdrop glitch — align STEP_VENDOR with sibling IOU steps #96532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Beamanator wants to merge 2 commits into from
+2 −0
Closed

Fix Supplier RHP backdrop glitch — align STEP_VENDOR with sibling IOU steps #96532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e536296
Fix backdrop glitch when opening Supplier RHP from expense view
Beamanator Jul 20, 2026
334624b
Restore usePolicyForTransaction to preserve unreported non-reimbursab…
Beamanator Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libs/Navigation/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2035,6 +2035,8 @@ type MoneyRequestNavigatorParamList = {
transactionID: string;
reportActionID?: string;
reportID: string;
// eslint-disable-next-line no-restricted-syntax -- `backTo` usages in this file are legacy. Do not add new `backTo` params to screens. See contributingGuides/NAVIGATION.md
backTo: Routes;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a runtime change for the vendor RHP glitch

In the expense-view Supplier flow I inspected, MoneyRequestView already passes getReportRHPActiveRoute() into ROUTES.MONEY_REQUEST_STEP_VENDOR.getRoute(...), and the tab-swap code in linkTo/swapBackgroundTabForRHPTarget only checks the runtime route.params.backTo. This new backTo entry is just a TypeScript param-list annotation and is erased from the bundle, so it cannot change how getMatchingFullScreenRoute sees the route or fix the reported backdrop flicker when opening the Supplier RHP.

Useful? React with 👍 / 👎.

@Beamanator Beamanator Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from Alex's Claude agent

You are right — the backTo addition is TS-only, cannot change runtime linking behavior. Closing this PR. Will reopen once I have a proper local repro to identify the actual runtime cause of the backdrop rebuild.

};
[SCREENS.MONEY_REQUEST.STEP_CATEGORY_CREATE]: {
action: IOUAction;
Expand Down
Loading