Skip to content

Fix expense header More menu overlap and missing bottom padding after duplicating#96555

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixDuplicateHeaderPadding
Draft

Fix expense header More menu overlap and missing bottom padding after duplicating#96555
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixDuplicateHeaderPadding

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

This fixes a deploy blocker introduced by #90403. That PR added styles.mtn1 (marginTop: -4) to the separate-line actions wrapper and to the status-bar row in MoneyRequestHeader.tsx. When an expense is duplicated, the "duplicate" status bar renders and the header switches into the status-bar branch, where the negative top margins pull the rows up so the opened More (⋯) menu overlaps the action buttons and the bottom padding effectively disappears.

The fix removes the two styles.mtn1 negative margins so the rows no longer overlap, restoring the pre-#90403 [ph5, pb3] spacing on the status-bar row (which keeps the intended 12px bottom padding). The separate-line actions are rendered directly again instead of being wrapped in an extra negative-margin View. The new inline "actions next to the status bar" behavior from #90403 is preserved.

⚠️ This is a targeted layout/CSS change. Static checks (oxfmt, lint, tsc) pass, but the exact pixel spacing should be visually verified on the repro (workspace chat → create expense → open report → More > Duplicate → More) before marking Ready for review.

Fixed Issues

$ #96548
PROPOSAL: #96548 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review". Suggested repro to verify: workspace chat → create an expense → open the report → More > Duplicate → click More, and confirm the More menu does not cover the action buttons and there is padding at the bottom.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review". Please describe what QA needs to do to validate your changes and what areas they need to test for regressions (e.g. the expense header status bar for on-hold, scanning, pending, and broken-connection states).

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

… bottom padding in expense header status bar

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the failing checks. Good news: there's no code problem to fix here.

All the real CI checks pass — typecheck, all 8 test jobs, ESLint, Oxfmt, tsc, knip, Storybook, the builds, and the perf jobs are all green.

The only red check is PR Author Checklist / checklist, and the job log shows why:

You completed 0 out of 38 checklist items with 38 unfinished items
##[error]PR Author Checklist is not completely filled out.

That's the author-checklist gate, not a bug in the code. It only goes green once the boxes in the PR Author Checklist section are ticked — and I can't check those on a human's behalf, since they're attestations that you (the human co-author) ran/verified each item. The PR body already flags this with a // TODO noting the human co-author needs to fill out the Tests / QA Steps sections and complete the checklist before marking the PR Ready for review.

Next step (for you): as noted in the PR description, please visually verify the fix on the repro (workspace chat → create expense → open report → More > DuplicateMore, confirm the More menu doesn't cover the action buttons and there's bottom padding), fill in the Tests/QA sections, and check the author-checklist boxes. That will turn the checklist check green.

Since there was no actual failing check to push a code fix for, I haven't made any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants