Fix expense header More menu overlap and missing bottom padding after duplicating#96555
Fix expense header More menu overlap and missing bottom padding after duplicating#96555MelvinBot wants to merge 1 commit into
Conversation
… bottom padding in expense header status bar Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
|
I looked into the failing checks. Good news: there's no code problem to fix here. All the real CI checks pass — The only red check is
That's the author-checklist gate, not a bug in the code. It only goes green once the boxes in the PR Author Checklist section are ticked — and I can't check those on a human's behalf, since they're attestations that you (the human co-author) ran/verified each item. The PR body already flags this with a Next step (for you): as noted in the PR description, please visually verify the fix on the repro (workspace chat → create expense → open report → More > Duplicate → More, confirm the More menu doesn't cover the action buttons and there's bottom padding), fill in the Tests/QA sections, and check the author-checklist boxes. That will turn the Since there was no actual failing check to push a code fix for, I haven't made any changes. |
Explanation of Change
This fixes a deploy blocker introduced by #90403. That PR added
styles.mtn1(marginTop: -4) to the separate-line actions wrapper and to the status-bar row inMoneyRequestHeader.tsx. When an expense is duplicated, the "duplicate" status bar renders and the header switches into the status-bar branch, where the negative top margins pull the rows up so the opened More (⋯) menu overlaps the action buttons and the bottom padding effectively disappears.The fix removes the two
styles.mtn1negative margins so the rows no longer overlap, restoring the pre-#90403[ph5, pb3]spacing on the status-bar row (which keeps the intended 12px bottom padding). The separate-line actions are rendered directly again instead of being wrapped in an extra negative-marginView. The new inline "actions next to the status bar" behavior from #90403 is preserved.Fixed Issues
$ #96548
PROPOSAL: #96548 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review". Suggested repro to verify: workspace chat → create an expense → open the report → More > Duplicate → click More, and confirm the More menu does not cover the action buttons and there is padding at the bottom.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review". Please describe what QA needs to do to validate your changes and what areas they need to test for regressions (e.g. the expense header status bar for on-hold, scanning, pending, and broken-connection states).
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari