Skip to content

Fix participant picker flashing on Create expense when Submissions are disabled#96561

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixParticipantPickerFlash
Draft

Fix participant picker flashing on Create expense when Submissions are disabled#96561
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixParticipantPickerFlash

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixes the deploy blocker where the participant (recipient) list briefly appears and then disappears when opening FAB → Create expense on a workspace with Submissions disabled.

Root cause: After PR #96228 removed the NEW_MANUAL_EXPENSE_FLOW beta and made the embedded-confirmation + auto-opening participant picker the default, the auto-open decision (shouldAutoOpenParticipantPicker) is derived purely from whether defaultParticipants is currently populated — it has no "still loading" state. On the first render(s) the Onyx sources that resolve the default destination haven't hydrated yet, so defaultParticipants is momentarily empty and the picker auto-opens. A beat later the default resolves (via the self‑DM branch when auto‑reporting/Submissions is off — see useDefaultParticipants.ts), the auto‑assign effect fires and the picker closes — the visible flash. It only reproduces with Submissions disabled because the self‑DM branch settles a render or two behind the policy‑expense‑chat branch used when Submissions are enabled.

Fix: useDefaultParticipants now also reports whether the Onyx data backing the resolution is still hydrating (isLoading), computed from the load status of the collections/keys the resolution reads (POLICY, REPORT, and the billing NVPs). All the lagging sub-hooks (useDefaultExpensePolicy, useSelfDMReport) and getPolicyExpenseChat derive from those same POLICY/REPORT collections, so isLoading stays true precisely during the hydration window. IOURequestStepConfirmation now keeps shouldAutoOpenParticipantPicker false while isLoading is true, so an "empty because not resolved yet" state no longer flashes the picker. Once the data settles, a genuinely empty default still opens the picker as before. The status-only collection subscriptions use a constant selector so they don't add value-driven re-renders.

⚠️ Note for the co-author: MelvinBot could not execute the local AI checks (lint/typecheck/jest/react-compiler) in its environment, so those are being relied upon via CI here. Please run them locally and QA the exact repro (workspace with Submissions disabled → FAB → Create expense → the participant list must not appear at all), plus a regression pass on the normal create-expense flow (Submissions enabled, workspace-chat entry point, and the genuine no-default case where the picker should still auto-open) before marking ready.

Fixed Issues

$ #96558
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review". Suggested: 1) Create a workspace and disable Submissions in Workflows. 2) Open FAB → Create expense. 3) Verify the participant list does NOT appear (no flash). 4) Regression: with Submissions enabled and from a workspace chat, verify create expense still works; verify the picker still auto-opens when there is genuinely no default participant.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…sabled

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useDefaultParticipants.ts 88.88% <100.00%> (+2.52%) ⬆️
src/hooks/useResetIOUType.ts 97.29% <100.00%> (ø)
...es/iou/request/step/IOURequestStepConfirmation.tsx 64.16% <66.66%> (-0.09%) ⬇️
... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants