Skip to content

Fix submit via PDF cancelation #96602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iwiznia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix submit via PDF cancelation #96602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/MoneyReportHeaderPrimaryAction/SubmitPrimaryAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,10 @@ function SubmitPrimaryActionContent({reportID}: SubmitPrimaryActionProps) {
// If the user cancels while the PDF is still generating, discard the submission (retract it back
// to draft) so they can resubmit — matching the pre-submit-via-PDF behavior.
openPDFDownload({
onCancel: () =>
onCancel: () => {
// Stop the "Submitted" animation in lockstep with the retract so the header goes straight
// back to the Submit button instead of finishing the animation on a report that is open again.
stopAnimation();
retractReport(
moneyRequestReport,
chatReport,
Expand All @@ -185,7 +188,8 @@ function SubmitPrimaryActionContent({reportID}: SubmitPrimaryActionProps) {
nextStep,
delegateEmail,
isTrackIntentUser,
),
);
},
});
}
},
Expand Down
Loading