Remove workspaceRoomsPage beta and release Workspace Rooms page#96603
Merged
grgia merged 1 commit intoJul 21, 2026
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
sumo-slonik
marked this pull request as ready for review
July 21, 2026 09:24
melvin-bot
Bot
requested review from
JmillsExpensify and
rojiphil
and removed request for
a team
July 21, 2026 09:24
grgia
approved these changes
Jul 21, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
Note, Beta was already released to * |
Contributor
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR releases the Workspace Rooms feature to everyone by removing the
workspaceRoomsPagebeta flag:WORKSPACE_ROOMS_PAGEfromCONST.BETAS.isBetaEnabled.WorkspaceRoomsPageandWorkspaceRoomCreatePageno longer passshouldBeBlockedtoAccessOrNotFoundWrapper— access is now controlled only by the standard policy-access checks.Since this releases the whole feature, the test steps below cover the full Workspace Rooms flow to ensure a complete review.
Fixed Issues
$ #93416
PROPOSAL:
Tests
Use an account that is not in the
workspaceRoomsPagebeta.#icon) appears in the left menu, directly below Members.#admins,#announce) in alphabetical order, each row showing the room avatar, name and member count.Offline tests
Unnecessary — this PR only removes a beta gate, no offline behavior changes.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-07-21.at.11.20.38.mov