Skip to content

Use ActivityIndicator for embedded IOURequestStepConfirmation loading-transaction early return #96825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 4 commits into from
Aug 19, 2026
Merged

Use ActivityIndicator for embedded IOURequestStepConfirmation loading-transaction early return #96825

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0e2b96
Use ActivityIndicator for embedded confirmation loading-transaction e…
MelvinBot Jul 23, 2026
88d6816
Add shouldUseGoBackButton to standalone FullScreenLoadingIndicator (U…
MelvinBot Aug 3, 2026
33776b7
Merge remote-tracking branch 'origin/main' into claude-iouConfirmatio…
MelvinBot Aug 4, 2026
b372ed1
Merge remote-tracking branch 'origin/main' into claude-iouConfirmatio…
MelvinBot Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/pages/iou/request/step/IOURequestStepConfirmation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import ActivityIndicator from '@components/ActivityIndicator';
import DragAndDropConsumer from '@components/DragAndDrop/Consumer';
import DragAndDropProvider from '@components/DragAndDrop/Provider';
import DropZoneUI from '@components/DropZone/DropZoneUI';
Expand Down Expand Up @@ -813,7 +814,16 @@ function IOURequestStepConfirmation({
};

if (isLoadingTransaction) {
return <FullScreenLoadingIndicator />;
// When embedded on IOURequestStartPage (shouldHideHeader), the parent header and tab bar stay visible,
// so per UI-1 use ActivityIndicator (the user can still go back). In the standalone RHP route there is
// no chrome behind this early return, so keep the fullscreen loader.
return shouldHideHeader ? (
<View style={[styles.flex1, styles.fullScreenLoading]}>
<ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />
</View>
) : (
<FullScreenLoadingIndicator shouldUseGoBackButton />
);
}

const showNextTransaction = () => {
Expand Down
Loading