[Home Page] Fix: Your spend section does not update after updating expense offline V2 - Greyed out - #96966
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e38e04291
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chrome2026-07-29.10.45.38.moviOS: HybridAppUploading Запись экрана — 2026-07-29 в 10.41.42.mov… iOS: mWeb Safari2026-07-29.10.41.42.movMacOS: Chrome / Safari2026-07-29.10.20.53.mov |
|
Something is wrong with the dev server today |
|
So 2026-07-29.10.33.35.mov |
|
But no 2026-07-29.10.45.38.mov |
|
I'm a bit confused 2026-07-29.10.57.54.mov |
Greying alone was inconsistent: local report mutations still moved the row state, so approving the last outstanding report offline hid the row and a stale Repaid row could appear, with the outcome depending on which snapshot happened to be cached.
|
@ZhenjaHorbach could you please test again? |
|
Still broken 😅 2026-07-31.10.15.36.mov |
|
@ZhenjaHorbach I am currently busy with some internal stuff, so I'll get back to this the day after tomorrow. Thanks for your patience! |
|
@grgia done |
…offline-your-spend-v2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d64f175848
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.4.57-0 🚀
|
Help site review — changes required ✅This PR greys out the Awaiting approval and Repaid in the last 30 days totals in the Your spend section on Home whenever a queued offline change may have made them stale, until the app is back online and refreshes them. That's a new user-visible behavior, so the help site needs a note. Docs PR: #99021 (draft) What changed: Added one FAQ entry — "Why is a Your spend total greyed out?" — to the existing Expensify Home Overview article, which already documents the Your spend section. No other help articles reference this behavior, so nothing else needs updating. Feature and label names (Your spend, Awaiting approval, Repaid in the last 30 days, Home) match the existing article verbatim and the labels in this PR. @adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR is created as a replacement for a more complicated solution implemented here #93081
Fixed Issues
$ #91370
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-24.at.15.41.22.mov