Skip to content

[Home Page] Fix: Your spend section does not update after updating expense offline V2 - Greyed out - #96966

Merged
grgia merged 9 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/fix-offline-your-spend-v2
Aug 19, 2026
Merged

[Home Page] Fix: Your spend section does not update after updating expense offline V2 - Greyed out#96966
grgia merged 9 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/fix-offline-your-spend-v2

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Home "Your spend" totals come from server search snapshots that can't refresh offline, so they stayed stale after offline actions.
  • We now grey out only the total a pending offline change would move, signalling it may be out of date until the next online refresh.

This PR is created as a replacement for a more complicated solution implemented here #93081

Fixed Issues

$ #91370
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Sign in with an account that owns a paid workspace and open the Home page so the "Your spend" section shows an "Awaiting approval" and a "Repaid" total.
  2. Go offline, then approve an outstanding report and pay another one; verify the "Awaiting approval" and "Repaid" totals grey out while the queued actions are pending.
  3. Go back online and verify both totals un-grey and refresh to their updated values, with no errors in the JS console.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-24.at.15.41.22.mov

@adamgrzybowski adamgrzybowski changed the title Home - Your spend section does not update after updating expense offline [Home Page] Fix: Your spend section does not update after updating expense offline V2 - Greyed out Jul 24, 2026
@adamgrzybowski
adamgrzybowski marked this pull request as ready for review July 24, 2026 13:48
@adamgrzybowski
adamgrzybowski requested review from a team as code owners July 24, 2026 13:48
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team July 24, 2026 13:48
@melvin-bot

melvin-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...rc/pages/home/YourSpendSection/SpendSummaryRow.tsx 90.24% <100.00%> (ø)
src/pages/home/YourSpendSection/index.tsx 96.87% <100.00%> (ø)
...rc/pages/home/YourSpendSection/useYourSpendData.ts 97.71% <97.89%> (-0.18%) ⬇️
... and 9 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e38e04291

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/SpendSummaryRow.tsx
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@ZhenjaHorbach

ZhenjaHorbach commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
2026-07-29.10.45.38.mov
iOS: HybridApp

Uploading Запись экрана — 2026-07-29 в 10.41.42.mov…

iOS: mWeb Safari
2026-07-29.10.41.42.mov
MacOS: Chrome / Safari
2026-07-29.10.20.53.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Something is wrong with the dev server today
But try to complete reviewing today when it is fixed

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

So
We are okay with just freezing Your spend section in offline mode
And any events won't affect this section
Right?

2026-07-29.10.33.35.mov

@ZhenjaHorbach

ZhenjaHorbach commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

But no
We can still update Your spend section in offline mode 😅

2026-07-29.10.45.38.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

I'm a bit confused
Because the flow is a bit broken 😅
That is, sometimes nothing happens
Sometimes, after approval, the approval field disappears, and the ready for payment field doesn't appear
And sometimes, after approval, the approval field disappears, and the ready for payment field appears

2026-07-29.10.57.54.mov

Greying alone was inconsistent: local report mutations still moved the row state, so
approving the last outstanding report offline hid the row and a stale Repaid row could
appear, with the outcome depending on which snapshot happened to be cached.
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach could you please test again?

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Still broken 😅
After changing the amount or approval and unapproval
The field does not immediately turn gray in offline mode

2026-07-31.10.15.36.mov

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach I am currently busy with some internal stuff, so I'll get back to this the day after tomorrow. Thanks for your patience!

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia done

@adamgrzybowski
adamgrzybowski marked this pull request as draft August 18, 2026 10:00
@adamgrzybowski
adamgrzybowski marked this pull request as ready for review August 18, 2026 10:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d64f175848

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts Outdated
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
@grgia
grgia merged commit e29ca36 into Expensify:main Aug 19, 2026
35 of 36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.57-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — changes required ✅

This PR greys out the Awaiting approval and Repaid in the last 30 days totals in the Your spend section on Home whenever a queued offline change may have made them stale, until the app is back online and refreshes them. That's a new user-visible behavior, so the help site needs a note.

Docs PR: #99021 (draft)

What changed: Added one FAQ entry — "Why is a Your spend total greyed out?" — to the existing Expensify Home Overview article, which already documents the Your spend section. No other help articles reference this behavior, so nothing else needs updating.

Feature and label names (Your spend, Awaiting approval, Repaid in the last 30 days, Home) match the existing article verbatim and the labels in this PR.


@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants