Skip to content

Standardize Expense Report and Expense header with predictable button placement and carousel counter - #97005

Merged
JS00001 merged 13 commits into
Expensify:mainfrom
thelullabyy:fix-v2/90366
Aug 7, 2026
Merged

Standardize Expense Report and Expense header with predictable button placement and carousel counter#97005
JS00001 merged 13 commits into
Expensify:mainfrom
thelullabyy:fix-v2/90366

Conversation

@thelullabyy

@thelullabyy thelullabyy commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #90366
PROPOSAL: N/A

Tests

  • Setup
    Log in with a test account that has access to a paid workspace with multiple expense reports and expenses
    Have these in your test workspace:
  • At least 3 expense reports (mix of submitted/approved/paid states)
  • At least one expense report containing 3+ expenses
  1. Go to Spend --> Report/Expenses
  2. Verify that the expense/report header looks like this figure below for scenarios
  3. Verify that navigate using the carousel and ensure that all the expenses/reports from the list are available
image
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-05-17.at.23.29.29.mov

Bug: #96563

image
Android: mWeb Chrome
Screen.Recording.2026-05-17.at.23.25.25.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2026-05-17.at.23.21.16.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-17.at.23.15.10.mov

Bug: #96545

Screen.Recording.2026-07-27.at.20.19.00.mov

Bug: #96548

image

Bug: #96566

Screen.Recording.2026-07-27.at.21.06.31.mov

Bug: #96575

image

@melvin-bot

melvin-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
...tView/MoneyRequestReportTransactionsNavigation.tsx 96.87% <100.00%> (+95.78%) ⬆️
...archList/ListItem/TransactionGroupListExpanded.tsx 67.69% <ø> (ø)
...hooks/useMoneyReportHeaderMoreContentVisibility.ts 100.00% <100.00%> (ø)
src/libs/ExportOnyxState/common.ts 80.35% <ø> (ø)
src/pages/home/RecentlyAddedSection/index.tsx 100.00% <ø> (ø)
src/pages/inbox/ReportNavigateAwayHandler.tsx 70.51% <100.00%> (+0.38%) ⬆️
src/libs/actions/TransactionThreadNavigation.ts 71.42% <77.77%> (+0.46%) ⬆️
src/components/MoneyRequestHeader.tsx 0.00% <0.00%> (ø)
...RequestReportView/MoneyRequestReportNavigation.tsx 6.12% <0.00%> (-0.13%) ⬇️
... and 5 more
... and 8 files with indirect coverage changes

@thelullabyy
thelullabyy marked this pull request as ready for review July 27, 2026 14:53
@thelullabyy
thelullabyy requested review from a team as code owners July 27, 2026 14:53
@melvin-bot
melvin-bot Bot requested review from a team, brunovjk and heyjennahay and removed request for a team July 27, 2026 14:53
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and JS00001 and removed request for a team July 27, 2026 14:53
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@Eskalifer1 @JS00001 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@thelullabyy

Copy link
Copy Markdown
Contributor Author

I think @ShridharGoel will review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26b8dea34a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx Outdated
Comment thread src/components/MoneyReportHeaderMoreContent.tsx
@Eskalifer1

Copy link
Copy Markdown
Contributor

Hi @JS00001, please unassign me here, i am the second C+ here :)

@brunovjk

Copy link
Copy Markdown
Contributor

If my review isn't needed, please unassign me as well. Thanks.

@ShridharGoel

Copy link
Copy Markdown
Contributor

@thelullabyy Can you address the bot comments?

@trjExpensify

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🚧 trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@JS00001
JS00001 merged commit 9fdbedd into Expensify:main Aug 7, 2026
39 of 43 checks passed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97005.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9fdbedd-f1b9fa4-758bb92c321f49887819dafe6c7af98f894da28f/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://97005.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #98192 was identified to be related to this PR.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker ##98193 was identified to be related to this PR

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker #98196 was identified to be related to this PR

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #98200 was identified to be related to this PR

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.52-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review: no changes required 🟢

I reviewed the changes in this PR against the help site articles under App/docs/articles and no documentation updates are needed.

Why: This PR is a visual/layout standardization of the expense report and expense headers — it moves the report action buttons down next to the next-steps line, always renders the carousel counter with a consistent X of X label, and always shows the carousel for expenses opened from the Spend page. It doesn't add, rename, or change any feature, workflow, setting, or user-facing concept that the help site documents.

What I checked
  • Searched App/docs/articles for header/carousel/navigation terms (carousel, next steps, of total, prev/next, report/expense header, "navigate between", etc.).
  • The only carousel reference in the docs is in Getting-Started-with-the-Spend-Page.md, and it describes carousel navigation within report previews in the Inbox — a separate feature that this PR does not touch.
  • The general workflow articles (Create-and-Submit-Reports, Understanding-Report-Statuses-and-Actions, etc.) describe what the Submit/Approve/Pay actions do, not the pixel-level placement of those buttons or the carousel counter format — none of that documented behavior changes here.

Since no changes are required, I did not create a draft help site PR, apply the HelpDot label, or assign it.

@thelullabyy — this is a UI-only standardization with no documented behavior to update, so there's no linked help site PR to review. If you believe a specific article should call out the new header/carousel behavior, let me know which one and I'll draft the update.

@ShridharGoel ShridharGoel mentioned this pull request Aug 11, 2026
40 tasks
@JS00001 JS00001 mentioned this pull request Aug 11, 2026
55 tasks
JS00001 added a commit that referenced this pull request Aug 11, 2026
ikevin127 pushed a commit to ikevin127/Expensify that referenced this pull request Aug 11, 2026
roryabraham pushed a commit that referenced this pull request Aug 11, 2026
[cp staging] Revert #97005

(cherry picked from commit f3fbfef)

(cherry-picked to staging by roryabraham)
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.