Skip to content

Underline report action message links in high-contrast themes (WCAG 1.4.1) #97353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 1 commit into from
Jul 31, 2026
+6 −0
Merged

Underline report action message links in high-contrast themes (WCAG 1.4.1) #97353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ function AnchorRenderer({tnode, style, key}: AnchorRendererProps) {

const textDecorationLineStyle = isDeleted ? styles.lineThrough : {};

// In high-contrast themes, underline report action links so they are distinguishable by more than color (WCAG 1.4.1).
// The `styles.link` used by the non-comment link path above already handles this, but AnchorForCommentsOnly does not use it.
const highContrastUnderlineStyle = theme.isHighContrast ? styles.underline : {};

const onLinkPress = useMemo(() => {
if (internalNewExpensifyPath || internalExpensifyPath) {
return () => openLink(attrHref, environmentURL, isAttachment);
Expand Down Expand Up @@ -142,6 +146,7 @@ function AnchorRenderer({tnode, style, key}: AnchorRendererProps) {
style,
parentStyle,
styles.textDecorationLineNone,
highContrastUnderlineStyle,
textDecorationLineStyle,
styles.textUnderlinePositionUnder,
styles.textDecorationSkipInkNone,
Expand Down Expand Up @@ -169,6 +174,7 @@ function AnchorRenderer({tnode, style, key}: AnchorRendererProps) {
props.childTnode.getNativeStyles(),
parentStyle,
styles.textDecorationLineNone,
highContrastUnderlineStyle,
textDecorationLineStyle,
styles.textUnderlinePositionUnder,
styles.textDecorationSkipInkNone,
Expand Down
Loading