Skip to content

Fix composer hidden behind keyboard on cold start into a chat - #97357

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixComposerKeyboardAvoidingOnColdStart-bernhardoj
Draft

Fix composer hidden behind keyboard on cold start into a chat#97357
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixComposerKeyboardAvoidingOnColdStart-bernhardoj

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

On a cold start (force-quit then reopen), the app can restore directly into a report via the NavigationContainer's initialState, bypassing the LHN. React Navigation does not fire onStateChange for the initial state, and updateCurrentReportID was only ever called from the onStateChange handler — so currentReportID stayed unset ('') for that first restored report.

ReportScreen gates its keyboard-avoiding view on isTopMostReportId = currentReportID === reportIDFromRoute. With currentReportID empty, isTopMostReportId is false, so shouldEnableKeyboardAvoidingView is false and the composer is not lifted above the keyboard — it ends up hidden behind it. Navigating back to the LHN and reopening the chat fires a real state change, which is why the workaround restored correct behavior.

This change seeds currentReportID from the restored root state inside onReadyWithSentry (which runs once the container is ready), so isTopMostReportId is correct on the very first report screen after a cold start. The existing updateCurrentReportID guards mean it safely no-ops when the cold start lands on a non-report screen (e.g. Inbox or Settings).

Fixed Issues

$ #97295
PROPOSAL: #97295 (comment)

Tests

// TODO: The human co-author must fill out the manual test steps you ran before marking this PR as "ready for review".
// Suggested flow to validate: (1) open a chat and let it become the last-visited path, (2) force-quit the iOS app, (3) reopen so it restores directly into that chat, (4) tap the composer and verify it lifts above the keyboard with the cursor visible.

  • Verify that no errors appear in the JS console

Offline tests

// TODO: The human co-author must fill out any relevant offline test steps.

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the failing checks. There's nothing broken in the code — every automated check passes (typecheck, all 8 Jest test jobs, ESLint, Oxfmt, Storybook, perf tests, builds, spellcheck).

The only failing check is PR Author Checklist / checklist, and it fails simply because none of the 38 checklist boxes are ticked yet:

You completed 0 out of 38 checklist items with 38 unfinished items
PR Author Checklist is not completely filled out.

This one isn't something I can fix by pushing code — it needs you (the human co-author) to actually run the manual test/QA steps and check the boxes in the PR description. Several of those items assert things like "I tested on Android: Native / iOS: Native" and "I wrote clear testing steps," which I shouldn't tick on your behalf since they'd be untrue until a person verifies them.

To make this check pass:

  1. Fill in the Tests / Offline tests / QA Steps sections (the PR body currently has // TODO placeholders — I left a suggested validation flow in there for the cold-start composer fix).
  2. Add the screenshots/videos for the platforms you tested.
  3. Check off the applicable boxes in the PR Author Checklist once you've done each item.

Once the checklist is filled out, this check will go green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants