Skip to content

Fix - Expensify Card - Not here page opens after clicking Learn more in Settlement frequency - #97359

Open
FitseTLT wants to merge 2 commits into
Expensify:mainfrom
FitseTLT:fix-96742-expensify-card-learn-more-404
Open

Fix - Expensify Card - Not here page opens after clicking Learn more in Settlement frequency#97359
FitseTLT wants to merge 2 commits into
Expensify:mainfrom
FitseTLT:fix-96742-expensify-card-learn-more-404

Conversation

@FitseTLT

@FitseTLT FitseTLT commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The Learn more link in the Expensify Card Settlement frequency hint is hardcoded to MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK, which points at the Manage-Expensify-Cards slug. That article was deleted in June 2025 and the link has survived ever since only because of a redirect in docs/redirects.csv. On 2026-07-17 that redirect's target was renamed to Set-Up-and-Manage-the-Expensify-Card-US — a 98%-similarity rename, not a split; the UK/EU article was added separately a month earlier — and the replacement redirect never reached Cloudflare because the redirect deploy run for that merge failed. The old link now resolves 301 → 404 and the help site renders its "Hmm… it's not here" page.

This points the constant directly at the live Set-Up-and-Manage-the-Expensify-Card-US article, which is the unbroken continuation of the exact article the App has been trying to reach all along, so the link no longer depends on a redirect at all. It also updates the two docs/redirects.csv rows still targeting the retired un-suffixed slug — that is not what fixes the 404, but because the redirect workflow is path-filtered on docs/redirects.csv, merging it re-runs the stalled deploy and republishes the whole list, which is what restores the old URLs for already-released builds and external links.

Fixed Issues

$ #96742
PROPOSAL: #96742 (comment)

Tests

  1. Sign in as an admin of a workspace with the Expensify Card feature enabled on the US card program.
  2. Go to Workspace settings > Expensify Card > Settings.
  3. Click Learn more.
  4. Verify the help site opens https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US and renders the "Set Up and Manage the Expensify Card in the US" article — not the "Hmm… it's not here" 404 page.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
2026-07-29.19-00-45.mp4
iOS: Native
iOS: mWeb Safari
2026-07-29.18-54-28.mp4
MacOS: Chrome / Safari
2026-07-29.18-52-42.mp4

Point MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK at the live
Set-Up-and-Manage-the-Expensify-Card-US article, and collapse the two
redirects.csv rows that still target the retired
Set-Up-and-Manage-the-Expensify-Card slug.

Fixes Expensify#96742

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@FitseTLT
FitseTLT requested review from a team as code owners July 29, 2026 16:06
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team and heyjennahay July 29, 2026 16:06
@melvin-bot

melvin-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@melvin-bot
melvin-bot Bot removed the request for review from a team July 29, 2026 16:06
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review


Overall Assessment
This PR fixes a broken Learn more link in the Expensify Card Settlement frequency hint. It updates a hardcoded article URL in src/CONST/index.ts and two redirect target rows in docs/redirects.csv so they point at the live Set-Up-and-Manage-the-Expensify-Card-US slug instead of the retired Manage-Expensify-Cards slug.

Importantly, this PR does not add or modify any HelpDot article content (no .md article files are touched). It only changes a redirect mapping and a code constant. As a result, the article authoring governance in HELP_AUTHORING_GUIDELINES.md, HELPSITE_NAMING_CONVENTIONS.md, and TEMPLATE.md (heading rules, YAML frontmatter, FAQ structure, UI terminology, cross-linking, etc.) does not apply to these changes. The scoring criteria are designed for article prose and structure, which are absent here.

Scores Summary

  • Readability: N/A - No article prose was added or modified; nothing to assess against readability rules.
  • AI Readiness: N/A - No headings, YAML metadata, or article body were changed; retrieval-optimization criteria do not apply to a redirect CSV or a code constant.
  • Style Compliance: N/A - No UI-referencing text, button/tab naming, or FAQ content was introduced; naming conventions do not apply here.

    Key Findings
  • The change is a targeted, low-risk fix: it repoints a stale link to the live article slug rather than relying on a redirect chain that currently resolves 301 then 404.
  • The redirect-target updates in docs/redirects.csv are consistent with the constant change and also re-trigger the stalled redirect deploy workflow (path-filtered on docs/redirects.csv).
  • Both redirect rows and the constant now converge on the same canonical slug (Set-Up-and-Manage-the-Expensify-Card-US), avoiding divergence.
  • No article authoring standards are implicated, so there are no heading, metadata, terminology, or cross-linking concerns to raise.

    Recommendations
  • Priority: Confirm the target slug Set-Up-and-Manage-the-Expensify-Card-US is the correct canonical article for the US card program in the settlement-frequency context (the PR description notes a US/UK-EU split, so verify the hint should point to the US variant specifically).
  • Optional: Verify the redirect deploy workflow actually republishes after merge, since restoring already-released builds and external links depends on it.
  • No documentation-content actions are needed for this PR.

    Files Reviewed
  • docs/redirects.csv - Two redirect targets updated to the live slug. Not article content; no authoring rules apply.
  • src/CONST/index.ts - Hardcoded article link constant updated to the live slug. Code change, not documentation content.

    Note: No inline documentation comments were added because this PR contains no HelpDot article content to review line-by-line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant