Fix - Expensify Card - Not here page opens after clicking Learn more in Settlement frequency - #97359
Fix - Expensify Card - Not here page opens after clicking Learn more in Settlement frequency#97359FitseTLT wants to merge 2 commits into
Conversation
Point MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK at the live Set-Up-and-Manage-the-Expensify-Card-US article, and collapse the two redirects.csv rows that still target the retired Set-Up-and-Manage-the-Expensify-Card slug. Fixes Expensify#96742 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
HelpDot Documentation Review
|
Explanation of Change
The Learn more link in the Expensify Card Settlement frequency hint is hardcoded to
MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK, which points at theManage-Expensify-Cardsslug. That article was deleted in June 2025 and the link has survived ever since only because of a redirect indocs/redirects.csv. On 2026-07-17 that redirect's target was renamed toSet-Up-and-Manage-the-Expensify-Card-US— a 98%-similarity rename, not a split; the UK/EU article was added separately a month earlier — and the replacement redirect never reached Cloudflare because the redirect deploy run for that merge failed. The old link now resolves301 → 404and the help site renders its "Hmm… it's not here" page.This points the constant directly at the live
Set-Up-and-Manage-the-Expensify-Card-USarticle, which is the unbroken continuation of the exact article the App has been trying to reach all along, so the link no longer depends on a redirect at all. It also updates the twodocs/redirects.csvrows still targeting the retired un-suffixed slug — that is not what fixes the 404, but because the redirect workflow is path-filtered ondocs/redirects.csv, merging it re-runs the stalled deploy and republishes the whole list, which is what restores the old URLs for already-released builds and external links.Fixed Issues
$ #96742
PROPOSAL: #96742 (comment)
Tests
https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-USand renders the "Set Up and Manage the Expensify Card in the US" article — not the "Hmm… it's not here" 404 page.Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
2026-07-29.19-00-45.mp4
iOS: Native
iOS: mWeb Safari
2026-07-29.18-54-28.mp4
MacOS: Chrome / Safari
2026-07-29.18-52-42.mp4