Docs updates for E/A#94557 Save button on room settings pages - #97380
Docs updates for E/A#94557 Save button on room settings pages#97380MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: truph01 <truph01@users.noreply.github.com>
|
@MelvinBot Open this PR for review |
|
🤖 Done — this PR is now marked Ready for review.
|
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a single-line change; no inline comments were necessary. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Why these docs changes are needed
Companion help-site update for #94557, which adds a Save button to the Report/room settings single-select pages (Who can post, Notify me about new messages, Visibility) for the WCAG 3.2.2 fix.
Previously, selecting a row on these pages persisted the change and closed the page instantly. After #94557, the selection is held as a draft (the page stays open, the checkmark moves) and is only applied when the user taps the new Save button.
What changed
docs/articles/new-expensify/chat/Expensify-Chat-Rooms-for-Admins.md— the "Restrict Messaging to Admins Only" steps now include a Save step after selecting Admins only under Who can post, matching the new save-to-confirm behavior.Why nothing else changed
The room creation flow (
Create-a-New-Chat.md) uses a separate multi-field form with its own Create Room button and is unaffected by #94557. No existing article documents the step-by-step edit flow for a room's Visibility or a report's Notify me about new messages notification preference, so there was nothing to update there.@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.