Skip to content

Docs updates for E/A#94557 Save button on room settings pages - #97380

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-docs-report-settings-save-94557
Open

Docs updates for E/A#94557 Save button on room settings pages#97380
MelvinBot wants to merge 1 commit into
mainfrom
claude-docs-report-settings-save-94557

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Why these docs changes are needed

Companion help-site update for #94557, which adds a Save button to the Report/room settings single-select pages (Who can post, Notify me about new messages, Visibility) for the WCAG 3.2.2 fix.

Previously, selecting a row on these pages persisted the change and closed the page instantly. After #94557, the selection is held as a draft (the page stays open, the checkmark moves) and is only applied when the user taps the new Save button.

What changed

  • docs/articles/new-expensify/chat/Expensify-Chat-Rooms-for-Admins.md — the "Restrict Messaging to Admins Only" steps now include a Save step after selecting Admins only under Who can post, matching the new save-to-confirm behavior.

Why nothing else changed

The room creation flow (Create-a-New-Chat.md) uses a separate multi-field form with its own Create Room button and is unaffected by #94557. No existing article documents the step-by-step edit flow for a room's Visibility or a report's Notify me about new messages notification preference, so there was nothing to update there.


@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@truph01

truph01 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Open this PR for review

@MelvinBot
MelvinBot marked this pull request as ready for review July 30, 2026 09:05
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.

truph01 is assigned as the reviewer.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a single, focused documentation change: it adds one step (5. Click **Save**.) to the "Restrict Messaging to Admins Only" procedure in Expensify-Chat-Rooms-for-Admins.md. The change is a companion update for #94557, which introduces a Save button on the room settings single-select pages (save-to-confirm behavior). The addition accurately reflects the new UI flow and is correctly scoped, matching the PR author's stated reasoning for not touching other files.

Scores Summary

  • Readability: 10/10 - The added step is clear, concise, action-oriented, and slots naturally into the existing sequential numbered list.
  • AI Readiness: 10/10 - The step uses the UI-exact label and aligns the documented flow with actual product behavior, improving retrieval accuracy. No metadata or heading changes were needed for this diff.
  • Style Compliance: 10/10 - Click Save. matches the Button Naming Standards exactly: bold, sentence case, no quotation marks, no synonyms, and no altered capitalization.

Key Findings

  • The single added line fully complies with the Button Naming Standards in HELPSITE_NAMING_CONVENTIONS.md and the Step Formatting Standard (Section 5) in HELP_AUTHORING_GUIDELINES.md.
  • The step is correctly sequenced as step 5, immediately after selecting Admins only, matching the real save-to-confirm UI flow.
  • Scope is appropriate: room creation (Create-a-New-Chat.md) uses a separate Create Room button and is unaffected; no existing article documents the Visibility or notification-preference edit flows, so nothing else required updating.

Recommendations

  • No changes required. The diff is minimal, accurate, and fully governance-compliant.
  • Optional (out of scope for this PR): the pre-existing article uses multiple top-level headings ("Announce Room", "Admins Room") that are noun-only and conflict with the single-title, task-based heading rules. This is not part of the proposed change and should not block this PR, but could be addressed in a future cleanup.

Files Reviewed

  • docs/articles/new-expensify/chat/Expensify-Chat-Rooms-for-Admins.md - Approved. One step added; fully compliant.

Note: This is a single-line change; no inline comments were necessary.

@stephanieelliott
stephanieelliott requested a review from a team August 1, 2026 02:14
@melvin-bot

melvin-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested a review from bfitzexpensify August 1, 2026 02:14
@melvin-bot

melvin-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 1, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants