[No QA] Remove unsafe type assertions from tests

[KJ21-ENG]

Explanation of Change

Replace unsafe type assertions in the selected test fixtures and mocks with
production-derived types, typed mock helpers, and direct narrowing. The
navigation resize test now reads the live navigation state, forwards the exact
state to reset, and verifies that reset received that state. Test scenarios and
runtime behavior are preserved.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

1. Ran the Seatbelt Lite focused verifier for all 14 targets.
2. Verified all cleanup counts are zero, formatting and lint pass, and all 14
   target test files pass.
3. Verified exact-head Fork CI passed typecheck, lint, format, React Compiler,
   and Jest checks in provider run 30826369122.

Offline tests

N/A — this is a test-only cleanup with no application runtime or network behavior change.

QA Steps

N/A — this is a test-only cleanup; no staging or production QA flow is applicable.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Count change

Current baseline source:

• The canonical tracked config/eslint/eslint.seatbelt.tsv inventory on the pinned base.

Before:

• tests/actions/AppTest.ts: 4
• tests/actions/IOU/SearchUpdateTest.ts: 4
• tests/actions/IOUTest/HoldTest.ts: 4
• tests/actions/IOUTest/SendInvoiceTest.ts: 4
• tests/actions/IOUTest/UpdateMoneyRequestTest.ts: 4
• tests/actions/OnyxUpdateManagerTest.ts: 4
• tests/actions/connections/QuickbooksOnline.ts: 4
• tests/navigation/ResizeScreenTests.tsx: 4
• tests/perf-test/ReportActionsUtils.perf-test.ts: 4
• tests/ui/ProfilePageTest.tsx: 4
• tests/ui/ReportActionAvatarsTest.tsx: 4
• tests/ui/components/ComposedButton.tsx: 4
• tests/ui/components/IOURequestStepConfirmationPageTest.tsx: 4
• tests/unit/ValidateAttachmentFileTest.ts: 5

After:

• Every one of the 14 target files: 0.

Net reduction:

• 57 unsafe type-assertion cleanup entries removed.

TSV evidence:

• The verifier updated the canonical TSV for counting and restored it byte-for-byte after verification; the committed diff contains no TSV change.

Screenshots/Videos

N/A — this test-only cleanup introduces no user-facing UI change.

Changed files (14)

• tests/actions/AppTest.ts
• tests/actions/IOU/SearchUpdateTest.ts
• tests/actions/IOUTest/HoldTest.ts
• tests/actions/IOUTest/SendInvoiceTest.ts
• tests/actions/IOUTest/UpdateMoneyRequestTest.ts
• tests/actions/OnyxUpdateManagerTest.ts
• tests/actions/connections/QuickbooksOnline.ts
• tests/navigation/ResizeScreenTests.tsx
• tests/perf-test/ReportActionsUtils.perf-test.ts
• tests/ui/ProfilePageTest.tsx
• tests/ui/ReportActionAvatarsTest.tsx
• tests/ui/components/ComposedButton.tsx
• tests/ui/components/IOURequestStepConfirmationPageTest.tsx
• tests/unit/ValidateAttachmentFileTest.ts

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[KJ21-ENG]

@ikevin127 Could you please take a look at this when you get a chance? Thanks!

[ikevin127]

@KJ21-ENG Please let me know when this is ready for review - as I noticed it was marked as draft again.

[KJ21-ENG]

@ikevin127 Could you please take a look at this when you get a chance? Thanks!

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

[ikevin127]

🟢 LGTM

One of the stronger entries in the series. Alongside the usual jest.mocked() / createMock / typed-fetch-mock swaps, three files got genuinely better, not just retyped: ResizeScreenTests now asserts the hook forwards getState() into reset(), ReportActionsUtils.perf-test fixed a latent linkMetaData→linkmetadata typo the old as unknown as was hiding, and UpdateMoneyRequestTest replaced ?.value as OnyxEntry<SearchResults> with a proper Extract<OnyxUpdate<...>, {onyxMethod}> type-guarded .find.

No blockers.